Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color pickers #258

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add color pickers #258

merged 3 commits into from
Nov 5, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Nov 4, 2024

This PR:

  • adds three more color pickers for selected color, unselected color and frozen color.
  • splat shader is updated to support the configurable colors and is also simplified in the process
Screenshot 2024-11-04 at 11 51 33

@slimbuck slimbuck added the enhancement New feature label Nov 4, 2024
@slimbuck slimbuck requested a review from a team November 4, 2024 11:54
@slimbuck slimbuck self-assigned this Nov 4, 2024
willeastcott
willeastcott approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cooooooool. 👌

@slimbuck slimbuck merged commit ec3a7e9 into playcanvas:main Nov 5, 2024
2 checks passed
@slimbuck slimbuck deleted the view-colors-dev branch November 5, 2024 17:21
This was referenced Nov 6, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slimbuck @willeastcott