Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes aad aliases. Closes #5676 #6131

Closed
wants to merge 2 commits into from
Closed

Conversation

nanddeepn
Copy link
Contributor

Removes aad aliases. Closes #5676

  • Removed the clientside redirects from /cmd/aad to /cmd/entra in the docs.
  • Removed deprecated --aadGroupIds and --aadGroupNames options in spo group member add.
  • Removed deprecated --aadGroupIds and --aadGroupNames options in spo group member remove.
  • Removed deprecated --aadId option in spo user ensure.

@milanholemans milanholemans added the pr-major PR for the next major release label Jul 8, 2024
@milanholemans
Copy link
Contributor

Thank you @nanddeepn!

@Adam-it
Copy link
Contributor

Adam-it commented Jul 10, 2024

hi, this PR is now targeting v9.
But it does not mean this PR will be somehow on-hold. We just identified a breaking change issue we want to release ASAP with next major that's why we plan to release v8 a lot sooner to unblock our users with Power Automate commands.
v9 target is will be released shortly after (as planned), which most probably will be the end of September.
Thank you once again for your truly amazing effort in helping us build the best CLI in the world 👏😍. You Rock 🤩

@Adam-it
Copy link
Contributor

Adam-it commented Aug 3, 2024

hey @nanddeepn, it seems we have some conflicts after our last merges.
May I kindly ask you to rebase with the latest v9 and resolve them before we proceed 🙏. Let me know if you need any kind of help with that.
Thanks a ton 👏. You Rock 🤩

@Adam-it Adam-it marked this pull request as draft August 3, 2024 20:03
@nanddeepn nanddeepn marked this pull request as ready for review August 4, 2024 11:45
@nanddeepn nanddeepn force-pushed the issue-5676 branch 2 times, most recently from 249a1a0 to a53eedc Compare August 9, 2024 17:23
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Awesome work @nanddeepn 👏

Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nanddeepn what we missed in this change is

  • These aliasses can be removed when we start working
    that was mentioned in the related issue.
    it means we should remove all deprecation warnings like
    image

from the entra tree and get rid of aadCommands
image

also this change is almost the same as #6141
Lets consolidate those two changes to a single PR that closes two issues 🙏

@Adam-it Adam-it marked this pull request as draft August 11, 2024 21:17
@nanddeepn
Copy link
Contributor Author

nanddeepn commented Aug 14, 2024

This PR can be ignored now.

Concatenating two PRs to close #5823 and #5676 here - #6141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-major PR for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants