Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes aad options. Closes #5823 #6141

Closed
wants to merge 7 commits into from
Closed

Removes aad options. Closes #5823 #6141

wants to merge 7 commits into from

Conversation

nanddeepn
Copy link
Contributor

@nanddeepn nanddeepn commented Jul 12, 2024 •
edited
Loading

Removes aad options. Closes #5823 and #5676

@nanddeepn nanddeepn changed the title Removes aad options. Closes #5745 Removes aad options. Closes #5823 Jul 12, 2024
@milanholemans
Copy link
Contributor

Thanks @nanddeepn!

@milanholemans milanholemans added the pr-major PR for the next major release label Jul 12, 2024
@Adam-it Adam-it self-assigned this Aug 3, 2024
@Adam-it
Copy link
Contributor

Adam-it commented Aug 3, 2024

hey @nanddeepn may I kindly ask you to rebase with latest v9 and resolve the conflicts before we proceed 👍.
Let me know if you need any kind of help.
Thank you for your constant work and contributions to the community 👏. You Rock 🤩

@Adam-it Adam-it marked this pull request as draft August 3, 2024 20:27
@nanddeepn nanddeepn marked this pull request as ready for review August 4, 2024 11:14
@Adam-it Adam-it mentioned this pull request Aug 11, 2024
Closed
@Adam-it
Copy link
Contributor

Adam-it commented Aug 11, 2024

@nanddeepn this change is almost same as #6131. Lets concat those two PR's to a single change closing both issues.
Please let's leave the upgrade guidance from this PR since it is really helpful but we also need to add this new page to sidebar.ts 👍

@Adam-it Adam-it marked this pull request as draft August 11, 2024 21:22
@nanddeepn
Copy link
Contributor Author

Hi @Adam-it
Concating two PRs to close #5823 and #5676

@Adam-it
Copy link
Contributor

Adam-it commented Aug 14, 2024

Hi @Adam-it
Concating two PRs to close #5823 and #5676

Awesome 🤩😍

@nanddeepn nanddeepn marked this pull request as ready for review August 14, 2024 12:02
@Adam-it
Copy link
Contributor

Adam-it commented Aug 30, 2024

Due to an upcoming breaking change connected to CLI for Microsoft 365 login experience we will need to do a v9 release a bit sooner than we anticipated. Due to that we had to change the target of this PR to v10 which will be the next regular major release.

This was linked to issues Sep 18, 2024
Remove aad options #5823
Closed
Remove aad aliasses in the next major version #5676
Closed
milanholemans
milanholemans requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not forget to remove the alias blocks from the docs:

image

Also in the docusaurus.config.ts file. We have to remove the redirects for aad pages.

@Adam-it Adam-it changed the base branch from v10 to main September 30, 2024 13:29
@Adam-it
Copy link
Contributor

Adam-it commented Oct 11, 2024

@nanddeepn I am terribly sorry for a long hold up from my side due to other priority activities.
May I kindly ask you to rebase this branch with latest main so that we may proceed with the review?

@Adam-it Adam-it marked this pull request as draft October 11, 2024 08:21
@nanddeepn nanddeepn marked this pull request as ready for review October 11, 2024 09:16
Adam-it
Adam-it approved these changes Oct 13, 2024
View reviewed changes
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Adam-it
Copy link
Contributor

Adam-it commented Oct 13, 2024

Ready to merge 🚀

@Adam-it
Copy link
Contributor

Adam-it commented Oct 13, 2024

Merged manually. Thank you for your awesome contribution 👏.
You Rock 🤩

@Adam-it Adam-it closed this Oct 13, 2024
@nanddeepn nanddeepn deleted the issue-5823 branch October 16, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans milanholemans requested changes

@Adam-it Adam-it Adam-it approved these changes

Assignees

@Adam-it Adam-it

Labels
pr-major PR for the next major release pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove aad options Remove aad aliasses in the next major version
3 participants
@nanddeepn @milanholemans @Adam-it