Run Zookeeper container with user 'zookeeper' instead of 'root' #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pravega#538 Signed-off-by: Jan Høydahl <[email protected]>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 12 12
Lines 1613 1613
=======================================
Hits 1373 1373
Misses 155 155
Partials 85 85 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jan Høydahl <[email protected]>
janhoy
commented
Jun 28, 2023
| COPY --from=0 /zu/build/libs/zu.jar /opt/libs/ | ||
|
|
||
| RUN apt-get -q update && \ | ||
| chmod +x /usr/local/bin/* && \ | ||
| chown zookeeper:zookeeper /usr/local/bin/* /opt/libs/* && \ |
There was a problem hiding this comment.
Consolidating all commands in the same RUN will save one Docker layer. While it would probably work to keep these files owned by root it is clearer to let the user own them, as is the case for all files in the upstream image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Makes Zookeeper container run as user
zookeeperinstead of as 'root'Purpose of the change
Fixes #538
What the code does
Changes user in Dockerfile
How to verify it
Build the image and run Zookeeper. Verify that it runs as user
zookeeper.TODO: The zookeeper POD needs
fsGroup: 1000for this to work, so the mounted data PVC with be owned by thezookeepergroup.