Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Zookeeper container with user 'zookeeper' instead of 'root' #561

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Run Zookeeper container with user 'zookeeper' instead of 'root' #561

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ddae45
Run Zookeeper container with user 'zookeeper' instead of root
janhoy Jun 28, 2023
137ed8f
Change ownership of files from this dockerfile to 'zookeeper'
janhoy Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,11 @@ RUN ./gradlew --console=verbose --info shadowJar

FROM ${DOCKER_REGISTRY:+$DOCKER_REGISTRY/}zookeeper:3.7.1
COPY bin /usr/local/bin
RUN chmod +x /usr/local/bin/*
COPY --from=0 /zu/build/libs/zu.jar /opt/libs/

RUN apt-get -q update && \
chmod +x /usr/local/bin/* && \
chown zookeeper:zookeeper /usr/local/bin/* /opt/libs/* && \
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consolidating all commands in the same RUN will save one Docker layer. While it would probably work to keep these files owned by root it is clearer to let the user own them, as is the case for all files in the upstream image.

apt-get install -y dnsutils curl procps socat

USER zookeeper