Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native_max_local_exchange_partition_count session property #23910

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Add native_max_local_exchange_partition_count session property #23910

merged 4 commits into from
Oct 29, 2024

Conversation

arhimondr
Copy link
Member

@arhimondr arhimondr commented Oct 29, 2024 •
edited by tanjialiang
Loading

Description

Add native_max_local_exchange_partition_count session property

Motivation and Context

Maps to the max_local_exchange_partition_count Velox query property
introduced in facebookincubator/velox#11292

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Prestissimo (Native Execution) Changes
* Add ``native_max_local_exchange_partition_count session`` property. :pr:`23910`

@arhimondr arhimondr requested review from a team as code owners October 29, 2024 16:08
xiaoxmeng
xiaoxmeng approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arhimondr accepted with nit. Thanks!

...st/java/com/facebook/presto/nativeworker/AbstractTestNativeHiveExternalTableTpchQueries.java
@@ -114,7 +113,9 @@ public void tearDown()
for (String tableName : TPCH_TABLES) {
dropTableIfExists(javaQueryRunner, HIVE, TPCH, tableName);
}
assertUpdate(format("DROP SCHEMA IF EXISTS %s.%s", HIVE, TPCH));

// https://github.com/prestodb/presto/issues/23908
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove before land? Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented the following line to unblock. Created an issue to resolve it properly: #23908

Let me leave a comment on the issue to remove this comment once resolved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#23908 (comment)

xiaoxmeng
xiaoxmeng previously approved these changes Oct 29, 2024
View reviewed changes
@arhimondr arhimondr force-pushed the native_max_local_exchange_partition_count branch from 3aedb17 to c7f4f93 Compare October 29, 2024 17:09
@steveburnett
Copy link
Contributor

steveburnett commented Oct 29, 2024 •
edited
Loading

Suggest adding documentation for this session property to Presto C++ Session Properties.

Also, minor nit to include the PR number in the release note entry, and change the heading for consistency with the Order of sections in the Release Notes Guidelines.

== RELEASE NOTES ==
Prestissimo (Native Execution) Changes
* Add ``native_max_local_exchange_partition_count session`` property. :pr:`23910`

@arhimondr arhimondr force-pushed the native_max_local_exchange_partition_count branch from c7f4f93 to 6504f0a Compare October 29, 2024 17:56
steveburnett
steveburnett requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! Minor suggestion for the content. Please let me know, and maybe suggest a rephrasing, if you feel this sentence or one like it helps the reader.

presto-docs/src/main/sphinx/presto_cpp/properties-session.rst Outdated Show resolved Hide resolved
@arhimondr arhimondr force-pushed the native_max_local_exchange_partition_count branch from 6504f0a to 9701aec Compare October 29, 2024 19:14
steveburnett
steveburnett approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

@arhimondr arhimondr merged commit 2834ecc into prestodb:master Oct 29, 2024
61 checks passed
@arhimondr arhimondr deleted the native_max_local_exchange_partition_count branch October 29, 2024 20:45
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxmeng xiaoxmeng xiaoxmeng approved these changes

@NikhilCollooru NikhilCollooru NikhilCollooru approved these changes

@steveburnett steveburnett steveburnett approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

@elharo elharo Awaiting requested review from elharo elharo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arhimondr @steveburnett @NikhilCollooru @xiaoxmeng