Rewrite KOS15 #37
Merged
Rewrite KOS15 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th4s
requested changes
Jul 28, 2023
| @@ -0,0 +1,85 @@ | |||
| use derive_builder::Builder; | |||
|
|
|||
| /// KOS15 sender configuration. | |||
There was a problem hiding this comment.
Maybe a sentence explaining why Sender and Receiver each have sender_commit and receiver_commit.
There was a problem hiding this comment.
I removed the unused configurations
ot/mpz-ot/src/kos/mod.rs
Outdated
There was a problem hiding this comment.
Can we have some tests for check and verify failures, for the KOS check and KOS committed OT?
There was a problem hiding this comment.
This is tested in the core crate
themighty1
requested changes
Aug 1, 2023
sinui0
added a commit
that referenced
this pull request
Aug 30, 2023
* refactor kos15 * remove panic * fix derandomize * fix --no-default-features, and unused import * rebase fixes * sample delta with cointoss * remove unused config * update committed sender comments * PR comments * PR changes * add minimum extend check * decouple PayloadRecord * final PR changes
sinui0
added a commit
that referenced
this pull request
Aug 30, 2023
* refactor kos15 * remove panic * fix derandomize * fix --no-default-features, and unused import * rebase fixes * sample delta with cointoss * remove unused config * update committed sender comments * PR comments * PR changes * add minimum extend check * decouple PayloadRecord * final PR changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements KOS15, fixing some security and performance issues. There might be a couple odds and ends that still need to be buttoned up, but I wanted to open this now and start getting feedback sooner.
Changes
deltaused by the sender in the setup.