Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move key_begin and key_end members from scan_context to scan_info #121

Closed
wants to merge 1 commit into from

Move key_begin and key_end members from scan_context to scan_info

958d34b
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Closed

Move key_begin and key_end members from scan_context to scan_info #121

Move key_begin and key_end members from scan_context to scan_info
958d34b
Select commit
Loading
Failed to load commit list.
GitHub Actions / Clang-Tidy-pr failed Oct 16, 2024 in 0s

[Clang-Tidy] 28 warnings

[Clang-Tidy] 28 warnings

Annotations

Check warning on line 112 in src/./jogasaki/model/task.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

google-default-arguments

default arguments on virtual or override methods are prohibited 

Check warning on line 58 in src/jogasaki/executor/common/task.cpp

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

google-default-arguments

default arguments on virtual or override methods are prohibited 

Check failure on line 50 in src/jogasaki/executor/common/task.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

clang-diagnostic-inconsistent-missing-override

'dump' overrides a member function but is not marked 'override' 

Check warning on line 50 in src/jogasaki/executor/common/task.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

cppcoreguidelines-explicit-virtual-functions,hicpp-use-override,modernize-use-override

annotate this function with 'override' or (rarely) 'final' 

Check warning on line 50 in src/jogasaki/executor/common/task.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

google-default-arguments

default arguments on virtual or override methods are prohibited 

Check warning on line 41 in src/./jogasaki/executor/process/abstract/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

google-default-arguments

default arguments on virtual or override methods are prohibited 

Check warning on line 60 in src/./jogasaki/scheduler/task_factory.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

google-default-arguments

default arguments on virtual or override methods are prohibited 

Check failure on line 50 in src/./jogasaki/executor/common/task.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

clang-diagnostic-inconsistent-missing-override

'dump' overrides a member function but is not marked 'override' 

Check warning on line 50 in src/./jogasaki/executor/common/task.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

cppcoreguidelines-explicit-virtual-functions,hicpp-use-override,modernize-use-override

annotate this function with 'override' or (rarely) 'final' 

Check warning on line 50 in src/./jogasaki/executor/common/task.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

google-default-arguments

default arguments on virtual or override methods are prohibited 

Check failure on line 45 in src/./jogasaki/executor/process/impl/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

clang-diagnostic-defaulted-function-deleted

explicitly defaulted copy constructor is implicitly deleted 

Check failure on line 46 in src/./jogasaki/executor/process/impl/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

clang-diagnostic-defaulted-function-deleted

explicitly defaulted copy assignment operator is implicitly deleted 

Check failure on line 64 in src/./jogasaki/executor/process/impl/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

clang-diagnostic-inconsistent-missing-override

'dump' overrides a member function but is not marked 'override' 

Check warning on line 64 in src/./jogasaki/executor/process/impl/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

cppcoreguidelines-explicit-virtual-functions,hicpp-use-override,modernize-use-override

annotate this function with 'override' or (rarely) 'final' 

Check warning on line 64 in src/./jogasaki/executor/process/impl/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

google-default-arguments

default arguments on virtual or override methods are prohibited 

Check warning on line 41 in src/jogasaki/executor/process/abstract/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

google-default-arguments

default arguments on virtual or override methods are prohibited 

Check warning on line 89 in src/./jogasaki/executor/process/impl/task_context.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

modernize-use-nodiscard

function 'getImplWorkContext' should be marked [[nodiscard]] 

Check warning on line 97 in src/jogasaki/executor/process/impl/scan_info.cpp

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

google-default-arguments

default arguments on virtual or override methods are prohibited 

Check failure on line 45 in src/jogasaki/executor/process/impl/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

clang-diagnostic-defaulted-function-deleted

explicitly defaulted copy constructor is implicitly deleted 

Check failure on line 46 in src/jogasaki/executor/process/impl/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

clang-diagnostic-defaulted-function-deleted

explicitly defaulted copy assignment operator is implicitly deleted 

Check failure on line 64 in src/jogasaki/executor/process/impl/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

clang-diagnostic-inconsistent-missing-override

'dump' overrides a member function but is not marked 'override' 

Check warning on line 64 in src/jogasaki/executor/process/impl/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

cppcoreguidelines-explicit-virtual-functions,hicpp-use-override,modernize-use-override

annotate this function with 'override' or (rarely) 'final' 

Check warning on line 64 in src/jogasaki/executor/process/impl/scan_info.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

google-default-arguments

default arguments on virtual or override methods are prohibited 

Check warning on line 182 in src/jogasaki/executor/process/impl/task_context.cpp

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

readability-redundant-control-flow

redundant return statement at the end of a function with a void return type 

Check warning on line 89 in src/jogasaki/executor/process/impl/task_context.h

See this annotation in the file changed.

@github-actions github-actions / Clang-Tidy-pr

modernize-use-nodiscard

function 'getImplWorkContext' should be marked [[nodiscard]]