Avoid mixing GCC stage 1 content in final toolchain #36
Conversation
| @@ -52,7 +52,7 @@ fi | |||
| PROC_NR=$(getconf _NPROCESSORS_ONLN) | |||
|
|
|||
| ## Create and enter the toolchain/build directory | |||
| rm -rf build-$TARGET && mkdir build-$TARGET && cd build-$TARGET || { exit 1; } | |||
There was a problem hiding this comment.
All the exit 1 aren't longer needed as we have defined the onerr function
| make --quiet -j $PROC_NR all || { exit 1; } | ||
| make --quiet -j $PROC_NR install-strip || { exit 1; } | ||
| make --quiet -j $PROC_NR clean || { exit 1; } | ||
| make --quiet -j $PROC_NR clean |
There was a problem hiding this comment.
Disabling the compilation of some libraries to try to speed up the stage 1
|
This does build, but I'll need to do more testing. I think I'll have to build from scratch to be able to properly test it so none of the old files from the stage 1 build will still be there. |
I have moved it to draft, as it is still generating the |
|
Allright! I tested it, and it seems that this PR does indeed generate a correct limits.h. It includes the "include_next" at the end, which properly includes newlib's limits.h, making the headers valid (hence including PATH_MAX). |
Description
I was trying to compile https://github.com/google/googletest for PSP and I was facing some errors when finding the
MAX_PATHmacro.In theory the content of
MAX_PATHis in thelimits.hheader, coming fromnewlib, however,googletesteven includinglimits.hwasn't finding theMAX_PATHvariable.This was happening because we had conflicts with headers.
The very first one, was the file being used when compiling
googletest, this file shouldn't exist in our toolchain, however, the file is installed afer compilinggccstage 1.This is why I have created this PR.
The main scope of this PR is to be sure that GCC stage 1 content is shipped to a temporal folder, trying to avoid mixing it with the final content.
Additionally, other minor changes have been made.
Maybe there is a cleaner and smarter way to do this, but I couldn't find anything better.
Cheers