fix: Typing

publicodes · May 15, 2024 · e4c882c · e4c882c
1 parent ab403c4
commit e4c882c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/source/migrations/migrateSituation/getValueWithoutQuotes.ts b/source/migrations/migrateSituation/getValueWithoutQuotes.ts
@@ -1,4 +1,6 @@
-export function getValueWithoutQuotes(value: string | number) {
+import { NodeValue } from '../../../types/types'
+
+export function getValueWithoutQuotes(value: NodeValue) {
   if (
     typeof value !== 'string' ||
     !value.startsWith("'") ||

diff --git a/source/migrations/migrateSituation/handleSituationValuesMigration.ts b/source/migrations/migrateSituation/handleSituationValuesMigration.ts
@@ -22,7 +22,7 @@ function getMigratedValue({
   ruleName: DottedName
   nodeValue: NodeValue
   migrationInstructions: MigrationType
-}): string | number {
+}): NodeValue {
   if (
     typeof migrationInstructions.valuesToMigrate[ruleName][
       nodeValue as string

diff --git a/types/types.d.ts b/types/types.d.ts
@@ -1,7 +1,9 @@
 import { Evaluation } from 'publicodes'
 
+export type NodeValue = Evaluation
+
 export type Situation = {
-  [key: string]: string | number
+  [key: string]: NodeValue
 }
 
 export type DottedName = string
@@ -10,5 +12,3 @@ export type MigrationType = {
   keysToMigrate: Record<DottedName, DottedName>
   valuesToMigrate: Record<DottedName, Record<string, NodeValue>>
 }
-
-export type NodeValue = Evaluation