Refactor artifact cleanup #2649
Conversation
.github/workflows/release.yml
Outdated
| @@ -103,6 +103,7 @@ jobs: | |||
| with: | |||
| name: ${{ matrix.language }}-sdk.tar.gz | |||
| path: ${{ github.workspace}}/sdk/${{ matrix.language }}.tar.gz | |||
| retention-days: 30 | |||
There was a problem hiding this comment.
There's no equivalent of the previous skip-tags: true here. Doesn't that mean we'll lose release artifacts after 30 days?
There was a problem hiding this comment.
Yes, it would! Sounds like I was too eager here, and we should not add this to the release or prerelease workflows, using the default instead.
There was a problem hiding this comment.
I think I saw you mentioned somewhere that 30 is an override of the default value which is 90. Don't we have the same problem after 90 days currently?
There was a problem hiding this comment.
@mikhailshilkov: This is the current status quo as far as I'm aware. Here is a release run of 2 months ago with existing artifacts. Compare it to this release of 3 months ago - the artifacts are Expired.
If we want to keep them around for longer, we would have to come up with a new idea, but I'm unaware of any need for that.
TL;DR: The PR in its current state does not change the expiration duration of release (tagged) artifacts for the shorter.
… days. Remove artifact-cleanup job. Co-authored by: Alex Qiu <[email protected]>
guineveresaenger
force-pushed
the
guin/cleanup-artifacts-cleanup
branch
from
e5f56f2 to
6518cb8
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
This PR removes the artifact cleanup cron in favor of [setting retention days on the artifact upload itself](https://github.blog/changelog/2020-10-08-github-actions-ability-to-change-retention-days-for-artifacts-and-logs/). Fixes #2558. Similar to pulumi/pulumi-aws#2649
Fixes #2603
Co-authored by: Alex Qiu [email protected]