Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hebrew localization #149

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Add Hebrew localization #149

merged 1 commit into from
Oct 6, 2023

Conversation

clsn
Copy link

@clsn clsn commented Oct 6, 2023

Changes proposed in this pull request:

  • Add Hebrew translation .po file
  • Uses RIGHT-TO-LEFT MARK characters to try to keep bidirectionality sensible; may not be a good idea.

@hugovk hugovk changed the title Add Hebrew localization. Add Hebrew localization Oct 6, 2023
@hugovk hugovk added the changelog: Added For new features label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c5f30c6) 99.19% compared to head (9de77ed) 99.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files           9        9           
  Lines         746      746           
=======================================
  Hits          740      740           
  Misses          6        6           
Flag Coverage Δ
macos-latest 97.58% <ø> (ø)
ubuntu-latest 97.45% <ø> (ø)
windows-latest 96.11% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Uses RIGHT-TO-LEFT MARK characters to try to keep bidirectionality
sensible; may not be a good idea.
@hugovk
Copy link
Member

hugovk commented Oct 6, 2023

Thanks, let's try it out and we can make fixes if needed for bidirectionality.

@hugovk hugovk enabled auto-merge October 6, 2023 06:31
@hugovk hugovk merged commit e7c75ef into python-humanize:main Oct 6, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants