edit workflow to add support for ppc64le image generation #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zerpet
requested changes
Aug 4, 2023
Comment on lines
159
to
181
| - name: OCI Metadata for single-arch ppc64le image | ||
| #if: startsWith(github.ref, 'refs/tags/v') | ||
| id: single-arch-meta-ppc64le | ||
| uses: docker/metadata-action@v4 | ||
| with: | ||
| # list of Docker images to use as base name for tags | ||
| images: | | ||
| rabbitmqoperator/cluster-operator | ||
| flavor: | | ||
| latest=false | ||
| # generate Docker tags based on the following events/attributes | ||
| tags: | | ||
| type=semver,pattern={{version}},suffix=-ppc64le,latest=false | ||
| type=sha,suffix=-ppc64le,latest=false | ||
| - name: Build and push single-arch ppc64le image | ||
| #if: startsWith(github.ref, 'refs/tags/v') | ||
| uses: docker/build-push-action@v3 | ||
| with: | ||
| context: . | ||
| platforms: linux/ppc64le | ||
| push: ${{ github.event_name != 'pull_request' }} | ||
| tags: ${{ steps.single-arch-meta-ppc64le.outputs.tags }} | ||
| labels: ${{ steps.single-arch-meta-ppc64le.outputs.labels }} |
There was a problem hiding this comment.
We don't need a special case for single-arch image for ppc64. The other single-arch image cases are to workaround a limitation from one of our internal processes. The ppc64 arch won't flow as part of that internal process, so this case won't be needed
There was a problem hiding this comment.
@Zerpet Noted and removed single arch image case for ppc64le
|
CI fails because the fork doesn't have access to the repo secrets. The Operator builds fine, and that should be enough. The entire pipeline will run after merging. |
Zerpet
approved these changes
Aug 4, 2023
|
Thank you! |
|
@Zerpet when is your next release planned so we can avoid using sha value docker pull |
|
There's not much to release a new minor yet v2.4.0...main Probably after summer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1419
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
This PR edits github actions workflow and add support to generate ppc64le image along with amd64 and arm64.
Additional Context
None
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny: