Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit workflow to add support for ppc64le image generation #1421

Merged
merged 4 commits into from
Aug 4, 2023
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions .github/workflows/build-test-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
uses: docker/build-push-action@v3
with:
context: .
platforms: linux/amd64, linux/arm64
platforms: linux/amd64, linux/arm64, linux/ppc64le
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
Expand Down Expand Up @@ -155,7 +155,30 @@ jobs:
platforms: linux/arm64
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.single-arch-meta-arm64.outputs.tags }}
labels: ${{ steps.single-arch-meta-arm64.outputs.labels }}
labels: ${{ steps.single-arch-meta-arm64.outputs.labels }}
- name: OCI Metadata for single-arch ppc64le image
#if: startsWith(github.ref, 'refs/tags/v')
id: single-arch-meta-ppc64le
uses: docker/metadata-action@v4
with:
# list of Docker images to use as base name for tags
images: |
rabbitmqoperator/cluster-operator
flavor: |
latest=false
# generate Docker tags based on the following events/attributes
tags: |
type=semver,pattern={{version}},suffix=-ppc64le,latest=false
type=sha,suffix=-ppc64le,latest=false
- name: Build and push single-arch ppc64le image
#if: startsWith(github.ref, 'refs/tags/v')
uses: docker/build-push-action@v3
with:
context: .
platforms: linux/ppc64le
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.single-arch-meta-ppc64le.outputs.tags }}
labels: ${{ steps.single-arch-meta-ppc64le.outputs.labels }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need a special case for single-arch image for ppc64. The other single-arch image cases are to workaround a limitation from one of our internal processes. The ppc64 arch won't flow as part of that internal process, so this case won't be needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zerpet Noted and removed single arch image case for ppc64le

- name: Build manifest
if: github.event_name != 'pull_request'
env:
Expand Down
Loading