Including quorum logic for PUT and GET operations #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
rcmgleite
commented
Jun 1, 2024
rcmgleite
commented
- Included e2e tests
- multiple changes on the Error hierarchy
- new cmd ClusterState added so that tests can know when the state has been properly propagated
Existing issues: 1. Logic is really bad 2. API for client PUT and GET require a new boolean for replicaion - this is also pretty bad 3. On PUT, only the owner of the key will accept the PUT. This is not what a dynamo-style db would do.
The goal here is to include client facing tests so that implementing the cluster version of PUT and GET is easier Also included an initial graceful shutdown handling.
1. Very basic tests 2. A lot of infra code created in this single commit.. not great 3. The tests take forever to run because we have to wait for the cluster state to be propagated.. have to find a better way to do this 4. The server config is now hardcoded and not part of the test itself.. we should have a ServerBuilder to help with building test servers
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.