Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Including quorum logic for PUT and GET operations #3

Merged
merged 4 commits into from
Jun 1, 2024
Merged

Including quorum logic for PUT and GET operations #3

merged 4 commits into from
Jun 1, 2024

Commits on Jun 1, 2024

  1. Put and Get now work with quorum logic 

    Existing issues:

1. Logic is really bad
2. API for client PUT and GET require a new boolean for replicaion -
   this is also pretty bad
3. On PUT, only the owner of the key will accept the PUT. This is not
   what a dynamo-style db would do.
    @rcmgleite
    rcmgleite committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    3611729 View commit details
    Browse the repository at this point in the history

  2. Include e2e tests for standalone 

    The goal here is to include client facing tests so that implementing the
cluster version of PUT and GET is easier

Also included an initial graceful shutdown handling.
    @rcmgleite
    rcmgleite committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    9c3a111 View commit details
    Browse the repository at this point in the history

  3. Include e2e tests for cluster 

    1. Very basic tests
2. A lot of infra code created in this single commit.. not great
3. The tests take forever to run because we have to wait for the cluster
   state to be propagated.. have to find a better way to do this
4. The server config is now hardcoded and not part of the test itself..
   we should have a ServerBuilder to help with building test servers
    @rcmgleite
    rcmgleite committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    98a8cf6 View commit details
    Browse the repository at this point in the history

  4. Fix a bunch of clippy warnings

    @rcmgleite
    rcmgleite committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    4d4191e View commit details
    Browse the repository at this point in the history