Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sync]: ODH for rhoai 2.15 #387

Merged
merged 6 commits into from
Oct 18, 2024
Merged

[Sync]: ODH for rhoai 2.15 #387

merged 6 commits into from
Oct 18, 2024

Commits on Oct 18, 2024

  1. [sync]: update: remove webhook service from bundle 

    - ODH: cb86031

Signed-off-by: Wen Zhou <[email protected]>
    @zdtsw
    zdtsw committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    aba08c8 View commit details
    Browse the repository at this point in the history

  2. webhook: move initialization inside of the module (opendatahub-io#1284) 

    Add webhook.Init() function and hide webhook setup inside of the
module. It will make it possible to replace Init with a NOP (no
operation) with conditional compilation for no-webhook build.

Signed-off-by: Yauheni Kaliuta <[email protected]>
(cherry picked from commit e40c770)
    @ykaliuta @zdtsw
    ykaliuta authored and zdtsw committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7005427 View commit details
    Browse the repository at this point in the history

  3. Makefile, webhook: add run-nowebhook (opendatahub-io#1286) 

    Make it possible to compile operator without webhook enabled (with
-tags nowebhook). Create a stub webhook.Init() function for that.

Add run-nowebhook target to run webhook locally. It requires
`make install` to be executed on the cluster beforehand.

Since it repeats `make run`, move the command to a variable.
Also use variable RUN_ARGS for operator arguments. It makes it
possible to override them from the command line.

In VSCode it is possible to debug it with the following example
launch.json configuration:

```
        {
            "name": "Debug Operator No Webhook",
            "type": "go",
            "request": "launch",
            "mode": "debug",
            "program": "main.go",
            "buildFlags": [
                "-tags", "nowebhook"
            ],
            "env": {
                "OPERATOR_NAMESPACE": "opendatahub-operator-system",
                "DEFAULT_MANIFESTS_PATH": "./opt/manifests"
            },
            "args": [
                "--log-mode=devel"
            ],
            "cwd": "${workspaceFolder}",
        }
```

Signed-off-by: Yauheni Kaliuta <[email protected]>
(cherry picked from commit e8e266f)
    @ykaliuta @zdtsw
    ykaliuta authored and zdtsw committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    c54c8f8 View commit details
    Browse the repository at this point in the history

  4. update: use namespace dyniamically from operator env than hardcode va… 

    …lue (opendatahub-io#1298)

- thses are only needed when it is downstream speicific cases

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit fa63b4d)
    @zdtsw
    zdtsw committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    d46a2fe View commit details
    Browse the repository at this point in the history

  5. (fix): Change on trigger event to pull_request_target in the "Check… 

    … config and readme updates / Ensure generated files are included (pull_request)" action to fix "Resource not accessible by integration" error while running the action (opendatahub-io#1296)

Signed-off-by: AJAY JAGANATHAN <[email protected]>
(cherry picked from commit f954f0b)
    @AjayJagan @zdtsw
    AjayJagan authored and zdtsw committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e72dad2 View commit details
    Browse the repository at this point in the history

  6. fix: rebase from d46a2fe 

    Signed-off-by: Wen Zhou <[email protected]>
    @zdtsw
    zdtsw committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    783b4db View commit details
    Browse the repository at this point in the history