forked from NREL/buildstockbatch
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor docker_base to use inversion-of-control, and GCP to use that #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimum allowed coverage is Generated by 🐒 cobertura-action against 25b2e3d |
lathanh
changed the title
[DRAFT] Refactor docker_base to use inversion-of-control, and GCP to use that
Refactor docker_base to use inversion-of-control, and GCP to use that
Nov 22, 2023
nweires
reviewed
Nov 27, 2023
nweires
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Use inversion of control in
docker_base.prep_batches()
so that it can more strongly and easily ensure consistency between various implementations. Also refactor the GCP implementation to use that (the updateddocker_base.prep_batches()
).Checklist
Not all may apply
minimum_coverage
in.github/workflows/coverage.yml
as necessary.Update validation for project config yaml file changesUpdate existing documentationRun a small batch run on Eagle to make sure it all works if you made changes that will affect EagleAdd to the changelog_dev.rst file and propose migration text in the pull request