Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor docker_base to use inversion-of-control, and GCP to use that #34

Merged
merged 12 commits into from
Nov 29, 2023

Conversation

lathanh
Copy link
Member

@lathanh lathanh commented Nov 22, 2023

Pull Request Description

Use inversion of control in docker_base.prep_batches() so that it can more strongly and easily ensure consistency between various implementations. Also refactor the GCP implementation to use that (the updated docker_base.prep_batches()).

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@lathanh lathanh added the enhancement New feature or request label Nov 22, 2023
@lathanh lathanh requested a review from nweires November 22, 2023 01:31
@lathanh lathanh self-assigned this Nov 22, 2023
Copy link

github-actions bot commented Nov 22, 2023

File Coverage
All files 86%
base.py 90%
eagle.py 77%
exc.py 57%
local.py 70%
postprocessing.py 84%
utils.py 91%
cloud/docker_base.py 87%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against 25b2e3d

@lathanh lathanh marked this pull request as ready for review November 22, 2023 22:13
@lathanh lathanh changed the title [DRAFT] Refactor docker_base to use inversion-of-control, and GCP to use that Refactor docker_base to use inversion-of-control, and GCP to use that Nov 22, 2023
buildstockbatch/gcp/gcp.py Show resolved Hide resolved
buildstockbatch/cloud/docker_base.py Outdated Show resolved Hide resolved
buildstockbatch/test/test_docker_base.py Outdated Show resolved Hide resolved
buildstockbatch/test/test_docker_base.py Outdated Show resolved Hide resolved
@lathanh lathanh requested a review from nweires November 27, 2023 23:58
buildstockbatch/cloud/docker_base.py Show resolved Hide resolved
buildstockbatch/cloud/docker_base.py Outdated Show resolved Hide resolved
@lathanh lathanh merged commit 2829d9e into gcp Nov 29, 2023
4 checks passed
@lathanh lathanh deleted the lathanh/docker_base_ioc branch November 29, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants