Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Add support for Zilsd and Zcmlsd extension #117

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

lavanyajagan
Copy link
Collaborator

@lavanyajagan lavanyajagan commented Jun 18, 2024

Description

Adding Support for Zilsd and Zcmlsd Extensions presented here:

Related Issues

The related PRs

Update to/for Ratified/Unratified Extensions or to framework

  • Ratified
  • Unratified
  • Framework

List Extensions

The unratified spec document:
https://github.com/riscv/riscv-zilsd/blob/main/zilsd.adoc

Reference Model Used

  • SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • Make sure to have created a suitable entry in the CHANGELOG.md under [WIP-DEV] section.

@lavanyajagan lavanyajagan changed the title [Draft] Add support for Zilsd and Zcmlsd extension Add support for Zilsd and Zcmlsd extension Jul 5, 2024
@UmerShahidengr
Copy link
Collaborator

@lavanyajagan have you generated the ACTs based on these macros? If yes, then can you please provide those ACTs for review. Since this is unratified, and alot of work is pending for approval, it will be difficult to recreate the whole environment at my side and review this work.
ACTs will be easier to review.

@lavanyajagan
Copy link
Collaborator Author

ARCH test PR:

I will check with James to remove the "Draft". Could we provide a docker environment of the whole setup for you to re-run at your end?

@UmerShahidengr
Copy link
Collaborator

@lavanyajagan I have found the tests in riscv-arch-tests (PR#467), for some reason, you have declared the tests in a draft PR. When will you release it for official review? It seems like the draft email will keep your other ones in the queue.

@lavanyajagan
Copy link
Collaborator Author

The arch-test PR is updated. Also merge conflicts are resolved in this PR. Kindly review

@jamesbeyond
Copy link
Collaborator

Dear @lavanyajagan

The CTG and ISAC Repo had been moved to riscv-arch-test via PR
riscv-non-isa/riscv-arch-test#495

If you think this PR is important, and need to me merged on to risc-v CTG or ISAC, please re-submit your PR against riscv-arch-test

This repository shall be archived in about one week time .

@lavanyajagan
Copy link
Collaborator Author

We will update the arch test PR with these changes and update you. Thanks

@lavanyajagan
Copy link
Collaborator Author

Hi @jamesbeyond

We have updated the riscv-arch-tests PR (riscv-non-isa/riscv-arch-test#467) with the isac and ctg changes. If this gets approved, the other 2 PRs at the isac and ctg repos can be dropped

Best,
Lavanya

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants