-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move scattered CSRs #592
base: master
Are you sure you want to change the base?
Move scattered CSRs #592
Conversation
Excellent work! I'll take a look when we've excised N. |
Can you fix the conflicts (presumably due to N?) and then I'll take a look. |
b425bda
to
ccf9b1f
Compare
Fixed. Was from N and the addition of menvcfgh. |
This LGTM. There's definitely still organisational work to do after this (lots of files can be split up more), but we should probably defer that until after the new module system is in place. The only change I would suggest is very minor: there are a few places where it would improve readability to add blank lines e.g. change:
to
|
ccf9b1f
to
d645b32
Compare
Whitespace updated |
LGTM; can't see any reason not to merge this - I'll do it in a few days. |
d645b32
to
472456e
Compare
This is an initial attempt to relocate the newly scattered CSR functions and mappings.
I attempted to place everything related to a particular CSR together and in a logical place, but the compilation order of some of the files made this tricky. Especially
SAIL_SYS_SRCS
vsSAIL_REG_SRCS
. Thesail_sys_control.sail
file could probably do with a total restructuring.This is structured as a series of commits that each move logically grouped CSRs to make it easier to review.
For many of the CSRs, I had to make a judgment call about what seemed to make the most sense, but there are multiple good locations for many of them and we'll probably want to move several of them around before everyone is happy with this.