Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds an "connected surface mode" to the MLS visualization #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

planthaber
Copy link
Member

The lowest mls entries are drawn as mesh instead of individual quard, if activated (not default).
This eliminates visible gaps the the map representation (visible on the hills in the following pictures).

This approach does only changes the lowest surface, e.g. the first floor is drawn as before.
It is also expected that the MLS entires are ordered by position (lowest first).

Nevertheless, this can improve the visual quality of Screenshots or videos.

color_normal
color_connected

If the cycle color mode is switched off, "estimate normals" should be active:

grey_normal

grey_connected

@saarnold
Copy link
Member

saarnold commented Apr 5, 2016

This looks quite nice 👍
Will it also become part of the new MLSMap visualization?

@planthaber
Copy link
Member Author

I guess yes. In the end it isn't much complicated, I can add it to the new MLSMap once Christoph has finished refactoring

@chhtz
Copy link
Member

chhtz commented Apr 6, 2016

No objections against that. I guess the only complicated thing is implementing this to true multi-surface maps (with more than one surface). I also did not port "estimate normals" so far (also mostly because for sloped surfaces it is not necessary). OTOH, finding connected patches in MLS maps will be essential for navigation, later.

Refactoring is essentially done btw, you can add stuff, if you like.

@planthaber
Copy link
Member Author

"estimate normals", for the surface can also be done by an osg::SmoothVisitor, we only need to place the surface into a separate geode, so "estimate normals" is is a one liner. The smoothed vertical blocks are looking quite ugly when the visitor is applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants