Update GitHub Actions workflow #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents trailing zeroes from being removed by making the values strings not numbers.
The Ubuntu 22.04 is not supported for ROS. Temporarily remove it from the matrix until ROS 2 support is added to the workflow.
Replace nose with nose3 which is a "drop-in fork of nose v1 that is compatible with Python 2.7 and Python 3.3-3.10 without using lib2to3 or other compatibility layer"
Use pynose for Python 3.11+ support
Excluding tests for docker and for creating invalid directory paths. These tests do not seem relevant to testing superflore in a containerized CI/CD pipeline.
Update the checkout and setup-python actions to the latest versions. Remove Ubuntu 18.04 as a runner image as it has been deprecated by GitHub Actions and no longer as runners available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that you asked for the CI workflow to be updated for #299
I did a quick run at making the necessary changes. The commits are clean however since I was working in the GHA workflow editor some commits failed and had to be corrected. (eg switching from nose to nose3 then to pynose) I am happy to rework the series if you feel it is necessary.
You may see the workflow test runs I did here: https://github.com/robwoolley/superflore/actions