Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call super in Formatter.close methods to ensure sync is reset #3094

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Call super in Formatter.close methods to ensure sync is reset #3094

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
38abe6e
Call super in Formatter.close methods to ensure sync is reset
rahearn Jun 28, 2024
a4d72da
Try to move guard up into close method
rahearn Jun 30, 2024
8f660e4
Add test verifying that output.sync is reset when close is called
rahearn Jul 1, 2024
d7697b3
Add explicit guard for whether sync was started on an output that sup…
rahearn Jul 1, 2024
76aa327
Clean up forgotten commented-out code
rahearn Jul 1, 2024
8867e9d
Create struct with hash argument instead of keyword
rahearn Jul 1, 2024
b0aceb4
Oh yeah - old-style hash syntax
rahearn Jul 1, 2024
8d31de9
Address PR feedback
rahearn Jul 2, 2024
d62ec7a
Move reset sync test to a shared example group
rahearn Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/rspec/core/formatters/base_text_formatter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,11 @@ def seed(notification)
#
# @param _notification [NullNotification] (Ignored)
def close(_notification)
return if output.closed?

output.puts

output.flush
unless output.closed?
output.puts
output.flush
end
super
rahearn marked this conversation as resolved.
Show resolved Hide resolved
end
end
end
Expand Down
1 change: 1 addition & 0 deletions lib/rspec/core/formatters/json_formatter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def seed(notification)

def close(_notification)
output.write @output_hash.to_json
super
end

def dump_profile(profile)
Expand Down
Loading