Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate snap article (ko) #1943

Merged
merged 3 commits into from
Jan 1, 2019
Merged

Conversation

riseshia
Copy link
Member

@riseshia riseshia commented Jan 1, 2019

Translation of #1888
Ref #1894

Actual diff is bfb9042
Please review this @ruby/www-ruby-lang-org-i18n-ko 🙏

1 question: Is it better to translate snap...?

@riseshia riseshia requested a review from a team as a code owner January 1, 2019 13:26
ko/documentation/installation/index.md Outdated Show resolved Hide resolved
ko/news/_posts/2018-11-08-snap.md Outdated Show resolved Hide resolved
ko/news/_posts/2018-11-08-snap.md Outdated Show resolved Hide resolved
@riseshia
Copy link
Member Author

riseshia commented Jan 1, 2019

Applied reviews in e1e2bcd

Copy link
Member

@yous yous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@riseshia
Copy link
Member Author

riseshia commented Jan 1, 2019

Thanks for review!! XD

@riseshia riseshia merged commit 003344c into ruby:master Jan 1, 2019
@riseshia riseshia deleted the translate-snap-ko branch January 1, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants