New deserialization API - yet another bunch of preparations #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor: 1) aids readability; 2) allows sharing the common logic with soon-to-be-added deser_col_specs_borrowed.
|
|
muzarski
approved these changes
Oct 11, 2024
Similarly to what has been recently done with `deser_cql_type`, `deser_col_specs` is made a macro to avoid code duplication between owned and borrowed variant of that function. For now, to avoid warnings, borrowed variants of `deser_cql_type` and `deser_col_specs` are prefixed with an underscore. This will change once they are actually used.
When parsing rows, type check is a distinct phase in the new deserialization framework. To support propagation of errors related to type checking, a corresponding variant is added to RowsParseError.
RowsParseError is going to be a user-facing error type, because it is going to be returned from new QueryResult API. For convenient conversion into QueryError, a shortcut From impl is added.
wprzytula
force-pushed
the
new-deserialization-api-yet-another-preparatory-bunch
branch
from
41b79a4
to
5cb42fa
Compare
Lorak-mmk
approved these changes
Oct 11, 2024
wprzytula
deleted the
new-deserialization-api-yet-another-preparatory-bunch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #462
In order to make the main deserialization PR at least a bit smaller, I extracted another bunch of preparatory changes.
Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.