Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New deserialization API - yet another bunch of preparations #1088

Merged
merged 4 commits into from
Oct 11, 2024
Merged

New deserialization API - yet another bunch of preparations #1088

merged 4 commits into from
Oct 11, 2024

Commits on Oct 11, 2024

  1. result: extract deser_table_spec_for_col_spec 

    This refactor:
1) aids readability;
2) allows sharing the common logic with soon-to-be-added
   deser_col_specs_borrowed.
    @wprzytula
    wprzytula committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e5b1067 View commit details
    Browse the repository at this point in the history

  2. result: deser_col_specs as ownership-generic macro 

    Similarly to what has been recently done with `deser_cql_type`,
`deser_col_specs` is made a macro to avoid code duplication between
owned and borrowed variant of that function.

For now, to avoid warnings, borrowed variants of `deser_cql_type` and
`deser_col_specs` are prefixed with an underscore. This will change once
they are actually used.
    @wprzytula
    wprzytula committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4f9c860 View commit details
    Browse the repository at this point in the history

  3. RowsParseError: add variant for TypeCheckError 

    When parsing rows, type check is a distinct phase in the new
deserialization framework. To support propagation of errors related to
type checking, a corresponding variant is added to RowsParseError.
    @wprzytula
    wprzytula committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    413573c View commit details
    Browse the repository at this point in the history

  4. errors: impl From<RowsParseError> for QueryError 

    RowsParseError is going to be a user-facing error type, because it is
going to be returned from new QueryResult API. For convenient conversion
into QueryError, a shortcut From impl is added.
    @wprzytula
    wprzytula committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5cb42fa View commit details
    Browse the repository at this point in the history