-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to PyPy3.10 #4126
Open
gpotter2
wants to merge
1
commit into
secdev:master
Choose a base branch
from
gpotter2:pypy310
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Switch to PyPy3.10 #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4126 +/- ##
==========================================
- Coverage 82.17% 81.51% -0.66%
==========================================
Files 350 350
Lines 83261 83261
==========================================
- Hits 68419 67870 -549
- Misses 14842 15391 +549 |
polybassa
approved these changes
Sep 18, 2023
guedou
previously approved these changes
Sep 18, 2023
polybassa
previously approved these changes
Oct 10, 2023
This comment has been minimized.
This comment has been minimized.
Ugh. I don't want to have and debug this. whyyyyy pypy |
The macos failure is funny though.
As I understand is that was very, very unlikely :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking issues:
https://foss.heptapod.net/pypy/pypy/-/issues/4003
) in PyPy that breaks our tests when a backslash is used to break, so we need it to be fixed before merging this.https://github.com/google/brotli/issues/1072
(bypassed in Tests are failing under PyPy3 #4115 by pinning the version). I however don't expect this to be fixed any time soon, considering their track record.