Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyPy3.10 #4126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch to PyPy3.10 #4126

wants to merge 1 commit into from

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Sep 17, 2023

  • switch PyPy to 3.10

Breaking issues:

  • there's a bug (https://foss.heptapod.net/pypy/pypy/-/issues/4003) in PyPy that breaks our tests when a backslash is used to break, so we need it to be fixed before merging this.
  • brotli is currently having issues with the latest PyPy version: https://github.com/google/brotli/issues/1072 (bypassed in Tests are failing under PyPy3 #4115 by pinning the version). I however don't expect this to be fixed any time soon, considering their track record.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (01aeed2) to head (4cde487).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4126      +/-   ##
==========================================
- Coverage   82.17%   81.51%   -0.66%     
==========================================
  Files         350      350              
  Lines       83261    83261              
==========================================
- Hits        68419    67870     -549     
- Misses      14842    15391     +549     

see 21 files with indirect coverage changes

guedou
guedou previously approved these changes Sep 18, 2023
polybassa
polybassa previously approved these changes Oct 10, 2023
@STMhack

This comment has been minimized.

@gpotter2
Copy link
Member Author

Ugh. I don't want to have and debug this. whyyyyy pypy

@gpotter2
Copy link
Member Author

The macos failure is funny though.

###(063)=[failed] Test signal fuzzing offset 1

>>> test_offset = 100
>>> 
>>> class testFrame3(SignalPacket):
...     fields_desc = [
...         BEUnsignedSignalField("muxSig7", default=0, start=2, size=8, scaling=1, offset=test_offset),
...     ]
... 
>>> pkt = testFrame3()
>>> pkt = fuzz(pkt)
>>> 
>>> li = [pkt.muxSig7._fix() for x in range(100000)]
>>> 
>>> assert abs(round(sum(li) / len(li)) - 128 - test_offset) < 2
Traceback (most recent call last):
  File "<input>", line 2, in <module>
AssertionError

As I understand is that was very, very unlikely :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants