Fix unittests for pypy3.10 #4148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4148 +/- ##
==========================================
- Coverage 81.76% 81.76% -0.01%
==========================================
Files 330 330
Lines 76281 76281
==========================================
- Hits 62372 62369 -3
- Misses 13909 13912 +3 |
|
I disagree with this PR because this is a PyPy bug, as mentioned in the original issue. See https://foss.heptapod.net/pypy/pypy/-/issues/4003. My stance regarding PyPy support is: report the bugs, but do not adapt. Otherwise considering how often we have issues with PyPy it would be endless. |
|
ok.. I no problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gpotter2
In preparation for #4126, this PR removes just the "\" from various tests