[pull] F#SRC-2333_wait_for_tcp_joint_sub_melodic from ros-planning:melodic-devel #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
If an exception occurs while the GIL is released, it won't be reacquired and the stack unwinding will take place without the GIL. GILReleaser::release() and GILReleaser::reacquire() is removed, because it is unsafe.
* Move last_sent_command_ update from constructor to start * Tweak demo configs * Add install folders to CMakeLists * Add clarity to parameter warning
* Add a utility for logging collision pairs * Update printing style, rename function, move constants into the struct
Otherwise, we get entries like this in ompl_planning.yaml, where "None", of course, is not a valid planner config:
arm:
default_planner_config: None
* Rework velocity limit enforcement, add unit test * Test every command out of Servo * Minor variable renaming * Clang format & clang tidy * Delete unused acceleration variable
... to correctly rewrite shebang
It was just performing the operations of the default operator. Newer clang requires either both or none of copy constructor and assignment operator to be defined. warning: definition of implicit copy constructor for 'DistanceResultsData' is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]
* Enable/disable "Clear Octomap" button * Correctly remove octomap from scene in clearOctomap()
…ailure condition. (#2336)
…gs (#2928) While we need to pass execution_type to fake_moveit_controller_manager.launch, the controller_manager.launch files of real-robot shouldn't be required to define this argument. However, if they don't roslaunch fails with an `unused args` exception (see #2786). Passing arguments via pass_all_args should solve that issue.
Fixes the following error (occurring since 61d18f2) ``` [FATAL] ros.moveit_ros_planning.trajectory_execution_manager: Exception while loading controller manager 'robot': According to the loaded plugin descriptions the class robot with base class type moveit_controller_manager::MoveItControllerManager does not exist. ``` As we introduced `pass_all_args="true"`, the value of the argument `moveit_controller_manager` was the robot name.
- Rename MOVEIT_VERSION -> MOVEIT_VERSION_STR - MOVEIT_VERSION becomes a numeric identifier - Use like: #if MOVEIT_VERSION >= MOVEIT_VERSION_CHECK(1, 0, 0)
... reducing code duplication and facilitating re-use
Increase ccache size to 10G. This is particularly needed for ccov's debug build, which uses 8G according to the stats. Co-authored-by: Robert Haschke <[email protected]>
... as suggested by clang-tidy
Traditionally, PlanningPipeline parameters were defined in the private namespace of the move_group node. Since MoveIt 1.1.2 multiple pipeline configs are supported in parallel, defined as ~planning_pipelines/*. To support this new scheme as well (in a minimal fashion), we check for presence of the new scheme and use the parameters of the default pipeline, specified via the parameter ~default_planning_pipeline.
- Simplify many launch files to use the test_environment.launch files from moveit_resources@master - Provide compatibility to the Noetic-style configuration of (multiple) planning pipelines Only a single pipeline can be used at a time, specified via the ~default_planning_pipeline parameter.
…rCommand action (#2984) (#3091) This commit adds the `max_effort` parameter to the GripperCommand declaration in the `controller_list` (see issue #2956). This value is only used when effort is set in the requested gripper trajectory. Co-authored-by: Rick Staa <[email protected]> Co-authored-by: Jafar Abdi <[email protected]>
- Show output on error - Restore both stdout and stderr
- Create panda.urdf using catkin build panda_description - Improve debug output
... from noetic-devel branch and build docker images via GHA.
rhaschke
force-pushed
the
melodic-devel
branch
from
53d3ea3
to
2433d8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )