Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Switch OSP default to 17.1 ⚠️ #216

Merged
merged 5 commits into from
Sep 25, 2023
Merged

⚠️ Switch OSP default to 17.1 ⚠️ #216

merged 5 commits into from
Sep 25, 2023

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Aug 23, 2023 •
edited
Loading

  • Update README and add RHEL versions table
  • Move telco examples to 17.1
  • Add new example for 16.2
  • Updade vars defaults and add some doc too for storage on RHEL9
  • Skip some tasks in prepare_host for RHEL9
  • Add ntp_server parameter (with a safe default when not using RHSM) for deploying with a specific NTP.
  • Handle the RH container registry login when deploying Ceph.
    Unfortunately, redhat_registry_credentials is now a dict with mandatory username and password fields.
  • Make cephadm config working for DCN.
  • Allow to expose ceph_devices via LVM.

@EmilienM EmilienM mentioned this pull request Aug 23, 2023
Closed
@EmilienM
Copy link
Contributor Author

EmilienM commented Aug 23, 2023 •
edited
Loading

Some of us are currently testing it, I suggest that we wait for it to be merged.

Note that this brings backward incompatible changes to dev-install; so I produced a release today which will be usable for anyone who wants the default to work with 16.2 and RHEL 8.4.

@EmilienM EmilienM added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 23, 2023
@EmilienM EmilienM self-assigned this Aug 23, 2023
@EmilienM
Copy link
Contributor Author

I need to add support for NtpServer when using internal puddles. That's for Ceph; I'll explain in a next patchset, tomorrow.

@EmilienM EmilienM changed the title Switch OSP default to 17.1 WIP - Switch OSP default to 17.1 Aug 23, 2023
@EmilienM EmilienM marked this pull request as draft August 23, 2023 23:42
@EmilienM EmilienM changed the title WIP - Switch OSP default to 17.1 ⚠️ Switch OSP default to 17.1 ⚠️ Aug 24, 2023
@EmilienM EmilienM marked this pull request as ready for review August 24, 2023 13:47
@EmilienM EmilienM force-pushed the osp-17-1 branch 4 times, most recently from f72d17c to 087265b Compare August 24, 2023 15:57
MaysaMacedo
MaysaMacedo reviewed Aug 24, 2023
View reviewed changes
example-overrides/local-overrides-osp16-2-with-dpdk.yaml
@@ -1,9 +0,0 @@
dpdk_interface: enp130s0f0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this example being removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's renamed for 17.1. No point of duplicating examples for DPDK.

playbooks/vars/defaults.yaml
@@ -1,5 +1,5 @@
---
rhos_release: 16.2
rhos_release: 17.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to default all install types to 17.1?
on NFV we have this issue https://bugzilla.redhat.com/show_bug.cgi?id=2228643

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I know, but at the same time I don't think we should wait for the next FDP release (October AFIK).
dev-install users who want FDP should know that it's currently not working now in 17.1...

@EmilienM
Switch OSP default to 17.1
785f189 
* Update README and add RHEL versions table
* Move telco examples to 17.1
* Add new example for 16.2
* Updade vars defaults and add some doc too for storage on RHEL9
* Skip some tasks in prepare_host for RHEL9
* Add `ntp_server` parameter (with a safe default when not using RHSM)
  for deploying with a specific NTP.
* Handle the RH container registry login when deploying Ceph.
  Unfortunately, `redhat_registry_credentials` is now a dict with
  mandatory `username` and `password` fields.
@EmilienM EmilienM force-pushed the osp-17-1 branch 9 times, most recently from 703579c to 66b35c4 Compare August 29, 2023 23:53
@EmilienM
ceph deploy: become stack
cc435ad 
Required if the initial dev-install was done by e.g. `cloud-user`.
@EmilienM EmilienM force-pushed the osp-17-1 branch 4 times, most recently from c2a41d7 to 22758fc Compare August 30, 2023 01:08
@EmilienM EmilienM force-pushed the osp-17-1 branch 2 times, most recently from 66b9c64 to a382fcd Compare August 30, 2023 20:26
@MaysaMacedo
Copy link
Contributor

@EmilienM Is it ready for review?

@EmilienM
Copy link
Contributor Author

@EmilienM Is it ready for review?

Yes, I'm debugging something today but I'm not sure it involves dev-install.

@EmilienM
Copy link
Contributor Author

This is ready for review, @gprocunier had some comments (offline) but I think this can be addressed on a separate PR.

@MaysaMacedo
Copy link
Contributor

/lgtm
/hold if there is any extra test to perform

@EmilienM EmilienM merged commit cd9c6b0 into main Sep 25, 2023
1 check passed
@EmilienM EmilienM deleted the osp-17-1 branch September 25, 2023 17:54
@EmilienM
Copy link
Contributor Author

further fixes/improvements should come via another PR.

Thanks for the review, let's iterate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaysaMacedo MaysaMacedo MaysaMacedo left review comments

@mandre mandre Awaiting requested review from mandre

Assignees

@EmilienM EmilienM

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmilienM @MaysaMacedo