Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Append mode with resizing [WIP] #3148

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 8, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Support experipment-level upgrade_shape and resize.

Notes for Reviewer:

This PR is a work in progress. It is not ready for review.

@johnkerl johnkerl changed the base branch from main to kerl/py-resizer-connects October 8, 2024 16:31
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 8.00000% with 115 lines in your changes missing coverage. Please review.

Project coverage is 81.28%. Comparing base (50d63c1) to head (29c16a7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3148      +/-   ##
==========================================
- Coverage   82.92%   81.28%   -1.64%     
==========================================
  Files          50       51       +1     
  Lines        5229     5354     +125     
==========================================
+ Hits         4336     4352      +16     
- Misses        893     1002     +109     
Flag Coverage Δ
python 81.28% <8.00%> (-1.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 81.28% <8.00%> (-1.64%) ⬇️
libtiledbsoma ∅ <ø> (∅)

Base automatically changed from kerl/py-resizer-connects to main October 8, 2024 18:19
@johnkerl johnkerl force-pushed the kerl/py-exp-resize branch 3 times, most recently from 73934a7 to 8938131 Compare October 9, 2024 00:16
@johnkerl johnkerl mentioned this pull request Oct 9, 2024
@johnkerl johnkerl changed the base branch from main to kerl/py-can-upgrade-shape October 9, 2024 00:25
@johnkerl johnkerl force-pushed the kerl/py-exp-resize branch 12 times, most recently from 6f1fe0e to 57b7263 Compare October 9, 2024 03:46
@johnkerl johnkerl force-pushed the kerl/py-exp-resize branch 2 times, most recently from f269ee9 to adb5dc7 Compare October 9, 2024 03:59
@johnkerl johnkerl changed the base branch from kerl/py-can-upgrade-shape to kerl/registration-shape-acceessors October 9, 2024 04:01
@johnkerl johnkerl force-pushed the kerl/py-exp-resize branch 2 times, most recently from d4cd94e to bf17979 Compare October 9, 2024 04:27
Base automatically changed from kerl/registration-shape-acceessors to main October 9, 2024 13:51
@johnkerl johnkerl changed the title [python] Experiment-level shaping [WIP] [python] Append mode with resizing [WIP] Oct 9, 2024
@johnkerl johnkerl changed the base branch from main to kerl/py-exp-shaping2 October 9, 2024 20:56
Base automatically changed from kerl/py-exp-shaping2 to main October 10, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant