-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Append mode with resizing [WIP] #3148
Draft
johnkerl
wants to merge
2
commits into
main
Choose a base branch
from
kerl/py-exp-resize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3148 +/- ##
==========================================
- Coverage 82.92% 81.28% -1.64%
==========================================
Files 50 51 +1
Lines 5229 5354 +125
==========================================
+ Hits 4336 4352 +16
- Misses 893 1002 +109
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
force-pushed
the
kerl/py-exp-resize
branch
from
October 8, 2024 17:55
b41fe2e
to
f36d616
Compare
johnkerl
force-pushed
the
kerl/py-exp-resize
branch
3 times, most recently
from
October 9, 2024 00:16
73934a7
to
8938131
Compare
johnkerl
force-pushed
the
kerl/py-can-upgrade-shape
branch
from
October 9, 2024 00:25
5659d42
to
71929ba
Compare
johnkerl
force-pushed
the
kerl/py-exp-resize
branch
12 times, most recently
from
October 9, 2024 03:46
6f1fe0e
to
57b7263
Compare
johnkerl
force-pushed
the
kerl/py-exp-resize
branch
2 times, most recently
from
October 9, 2024 03:59
f269ee9
to
adb5dc7
Compare
johnkerl
changed the base branch from
kerl/py-can-upgrade-shape
to
kerl/registration-shape-acceessors
October 9, 2024 04:01
johnkerl
force-pushed
the
kerl/py-exp-resize
branch
2 times, most recently
from
October 9, 2024 04:27
d4cd94e
to
bf17979
Compare
johnkerl
force-pushed
the
kerl/py-exp-resize
branch
from
October 9, 2024 15:15
bf17979
to
015b195
Compare
This was referenced Oct 9, 2024
johnkerl
changed the title
[python] Experiment-level shaping [WIP]
[python] Append mode with resizing [WIP]
Oct 9, 2024
johnkerl
force-pushed
the
kerl/py-exp-resize
branch
from
October 9, 2024 20:56
015b195
to
2dd2887
Compare
johnkerl
force-pushed
the
kerl/py-exp-shaping2
branch
from
October 9, 2024 22:27
70c3c3a
to
fff5c72
Compare
johnkerl
force-pushed
the
kerl/py-exp-resize
branch
from
October 9, 2024 22:56
2dd2887
to
b53f9e6
Compare
johnkerl
force-pushed
the
kerl/py-exp-resize
branch
from
October 10, 2024 13:05
b53f9e6
to
08ac2d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As tracked on issue #2407 / [sc-51048].
Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
Support experipment-level
upgrade_shape
andresize
.Notes for Reviewer:
This PR is a work in progress. It is not ready for review.