Address audit issues #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow hyperlane mailbox as order recipient
dhfang
approved these changes
Oct 30, 2024
| @@ -266,6 +266,8 @@ contract FastTransferGateway is Initializable, UUPSUpgradeable, OwnableUpgradeab | |||
| /// @param repaymentAddress The address to repay the orders to | |||
| /// @param orderIDs The IDs of the orders to settle | |||
| function initiateSettlement(bytes32 repaymentAddress, bytes memory orderIDs) public payable { | |||
There was a problem hiding this comment.
It would also be nice to change _settleOrder to tally the amount to send and modify order status in the same loop like in the cosmwasm side for symmetry and to prevent the duplicate orderID issue at message receive independently of the message send implementation. Will leave it up to your discretion.
There was a problem hiding this comment.
Yeah you're right, I updated this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address findings found in our audit, the document can be found in our Telegram chat with them.