Code

Address audit issues#5

Code

Merged

thal0x merged 14 commits intomainskip-mev/go-fast-contracts:mainfrom jw/address-audit-findingsskip-mev/go-fast-contracts:jw/address-audit-findingsCopy head branch name to clipboardNov 6, 2024

+1,001-102

Commits

Commits on Oct 28, 2024

• update cosmwasm tests to use bech32 address for mailbox address

  thal0x

  committed
  c550512

• handle arbitrary calls through separate router contract and don't allow hyperlane mailbox as order recipient

  thal0x

  committed
  399ac95

• when initiating timeouts, validate orders destination domain is the local domain

  thal0x

  committed
  c81f846

• when calling initiateSettlement, revert on duplicate order id

  thal0x

  committed
  882a971

Commits on Oct 29, 2024

• add script to compare order encoding between cosmwasm and solidity

  thal0x

  committed
  5fb710a

• add script to compare order encoding between cosmwasm and solidity

  thal0x

  committed
  e204197

• use uint32 for nonce and uint64 for timeout timestamp

  thal0x

  committed
  b2461f9

• use forceApprove for erc20 token allowances

  thal0x

  committed
  0b90eba

• make evm and cosmwasm logic consistent for timeout checks

  thal0x

  committed
  b01d1cd

• address clippy issue

  thal0x

  committed
  d970de8

Commits on Oct 30, 2024

• fix merge conflict

  thal0x

  committed
  c4f4103

• remove second loop in the EVM settleOrders implementation

  thal0x

  committed
  733fb25

Commits on Oct 31, 2024

• forge install: skip-go-evm-contracts

  thal0x

  committed
  f9ccbef

Commits on Nov 6, 2024

• only allow gateway as caller in GoFastCaller

  thal0x

  committed
  f12611f