Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 Consolidate Neutron and Osmosis Query enum #53

Merged
merged 2 commits into from
Aug 7, 2023
Merged

🔥 Consolidate Neutron and Osmosis Query enum #53

merged 2 commits into from
Aug 7, 2023

Conversation

NotJeremyLiu
Copy link
Member

@NotJeremyLiu NotJeremyLiu commented Aug 7, 2023 •
edited
Loading

Background

  • Previously, IBC transfer adapter contracts stored a struct that was network-specific given an ack id. This was changed in ✨ Refund contract balance in ibc adapters instead of stored vars #19 to instead just store an address as a String (verified as a a valid address in entry point) on both contracts.
  • This allows us to then use the same query enum for both networks

This PR

  • Consolidates the multiple query enums into one.

@MaghnusM MaghnusM self-requested a review August 7, 2023 22:39
MaghnusM
MaghnusM approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@MaghnusM MaghnusM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good projet

@NotJeremyLiu NotJeremyLiu merged commit 6ae6778 into main Aug 7, 2023
3 checks passed
@NotJeremyLiu NotJeremyLiu deleted the jl/consolidate-ibc-transfer-queries branch August 7, 2023 22:42
@NotJeremyLiu NotJeremyLiu mentioned this pull request Aug 7, 2023
Open
15 tasks
@davidterpay
Copy link

just poppin by and saying hi

@davidterpay
Copy link

gm

@zrbecker zrbecker removed their request for review September 29, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaghnusM MaghnusM MaghnusM approved these changes

@wllmshao wllmshao Awaiting requested review from wllmshao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotJeremyLiu @davidterpay @MaghnusM