Fix license and chart version #33
Conversation
WalkthroughThe project has undergone a minor version update in its Helm chart, signifying a potential enhancement or fix in the deployment process. More notably, there's a significant shift in the licensing policy, moving from the permissive Apache License 2.0 to the more restrictive GPL 3.0, which could have implications on how the software can be used and shared. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -35,7 +35,7 @@ make deploy | |||
| Deploy using Helm (version 3.8.0 or later), which supports OCI charts. To use the helm chart, edit the `values.yaml` file and set `controllerManagerConfig.configYaml` to your Ceph cluster configuration like [secret.yaml](config/manager/secret.yaml). | |||
|
|
|||
| ```bash | |||
| helm upgrade --install ceph-s3-operator oci://ghcr.io/snapp-incubator/ceph-s3-operator/helm-charts/ceph-s3-operator --version v0.3.5 | |||
| helm upgrade --install ceph-s3-operator oci://ghcr.io/snapp-incubator/ceph-s3-operator/helm-charts/ceph-s3-operator --version v0.3.6 | |||
There was a problem hiding this comment.
Tip
Codebase Verification
The Helm chart's appVersion has been updated to v0.3.6 in charts/ceph-s3-operator/Chart.yaml, which corresponds with the version mentioned in the README.md. However, there is no evidence of the Helm chart's own version being updated to v0.3.6. This might indicate that the Helm chart itself may not have been updated to the new version, which could lead to inconsistencies or deployment issues. It is recommended to verify the Helm chart's version field to ensure it matches the intended release version.
Analysis chain
The Helm chart version has been updated from v0.3.5 to v0.3.6. Ensure that the Helm chart at the new version is available in the repository and that any dependent configurations or documentation have been updated accordingly.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify the Helm chart version v0.3.6 exists
rg --files-with-matches "version: v0.3.6" --glob 'charts/ceph-s3-operator/Chart.yaml'
Length of output: 85
Script:
#!/bin/bash
# Search for any Chart.yaml files in the repository
fd Chart.yaml
# Search for the string "v0.3.6" across the entire repository to check if the version is mentioned elsewhere
rg "v0.3.6"
Length of output: 348
| Deploy using Helm (version 3.8.0 or later), which supports OCI charts. To use the helm chart, edit the `values.yaml` file and set `controllerManagerConfig.configYaml` to your Ceph cluster configuration like [secret.yaml](config/manager/secret.yaml). | ||
|
|
||
| ```bash | ||
| helm upgrade --install ceph-s3-operator oci://ghcr.io/snapp-incubator/ceph-s3-operator/helm-charts/ceph-s3-operator --version v0.3.5 | ||
| helm upgrade --install ceph-s3-operator oci://ghcr.io/snapp-incubator/ceph-s3-operator/helm-charts/ceph-s3-operator --version v0.3.6 | ||
| ``` | ||
|
|
||
| ### Using OLM |
There was a problem hiding this comment.
📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The license badge still indicates the old Apache License 2.0. This should be updated to reflect the change to GPL 3.0 to avoid confusion.
- 
+ 
Summary by CodeRabbit