Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license and chart version #33

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix license and chart version #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ make deploy
Deploy using Helm (version 3.8.0 or later), which supports OCI charts. To use the helm chart, edit the `values.yaml` file and set `controllerManagerConfig.configYaml` to your Ceph cluster configuration like [secret.yaml](config/manager/secret.yaml).

```bash
helm upgrade --install ceph-s3-operator oci://ghcr.io/snapp-incubator/ceph-s3-operator/helm-charts/ceph-s3-operator --version v0.3.5
helm upgrade --install ceph-s3-operator oci://ghcr.io/snapp-incubator/ceph-s3-operator/helm-charts/ceph-s3-operator --version v0.3.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

The Helm chart's appVersion has been updated to v0.3.6 in charts/ceph-s3-operator/Chart.yaml, which corresponds with the version mentioned in the README.md. However, there is no evidence of the Helm chart's own version being updated to v0.3.6. This might indicate that the Helm chart itself may not have been updated to the new version, which could lead to inconsistencies or deployment issues. It is recommended to verify the Helm chart's version field to ensure it matches the intended release version.

Analysis chain

The Helm chart version has been updated from v0.3.5 to v0.3.6. Ensure that the Helm chart at the new version is available in the repository and that any dependent configurations or documentation have been updated accordingly.

Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the Helm chart version v0.3.6 exists
rg --files-with-matches "version: v0.3.6" --glob 'charts/ceph-s3-operator/Chart.yaml'

Length of output: 85

Script:

#!/bin/bash
# Search for any Chart.yaml files in the repository
fd Chart.yaml

# Search for the string "v0.3.6" across the entire repository to check if the version is mentioned elsewhere
rg "v0.3.6"

Length of output: 348

```

### Using OLM
Comment on lines 35 to 41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The license badge still indicates the old Apache License 2.0. This should be updated to reflect the change to GPL 3.0 to avoid confusion.

- ![License](https://img.shields.io/github/license/snapp-incubator/ceph-s3-operator)
+ ![License](https://img.shields.io/badge/license-GPLv3-blue.svg)

Expand Down Expand Up @@ -159,4 +159,4 @@ Contributions are warmly welcomed. Feel free to submit issues or pull requests.

## License

This project is licensed under the [Apache License 2.0](https://github.com/snapp-incubator/ceph-s3-operator/blob/main/LICENSE).
This project is licensed under the [GPL 3.0](https://github.com/snapp-incubator/ceph-s3-operator/blob/main/LICENSE).