-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix license and chart version #33
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ make deploy | |
Deploy using Helm (version 3.8.0 or later), which supports OCI charts. To use the helm chart, edit the `values.yaml` file and set `controllerManagerConfig.configYaml` to your Ceph cluster configuration like [secret.yaml](config/manager/secret.yaml). | ||
|
||
```bash | ||
helm upgrade --install ceph-s3-operator oci://ghcr.io/snapp-incubator/ceph-s3-operator/helm-charts/ceph-s3-operator --version v0.3.5 | ||
helm upgrade --install ceph-s3-operator oci://ghcr.io/snapp-incubator/ceph-s3-operator/helm-charts/ceph-s3-operator --version v0.3.6 | ||
``` | ||
|
||
### Using OLM | ||
Comment on lines
35
to
41
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The license badge still indicates the old Apache License 2.0. This should be updated to reflect the change to GPL 3.0 to avoid confusion. - ![License](https://img.shields.io/github/license/snapp-incubator/ceph-s3-operator)
+ ![License](https://img.shields.io/badge/license-GPLv3-blue.svg) |
||
|
@@ -159,4 +159,4 @@ Contributions are warmly welcomed. Feel free to submit issues or pull requests. | |
|
||
## License | ||
|
||
This project is licensed under the [Apache License 2.0](https://github.com/snapp-incubator/ceph-s3-operator/blob/main/LICENSE). | ||
This project is licensed under the [GPL 3.0](https://github.com/snapp-incubator/ceph-s3-operator/blob/main/LICENSE). |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The Helm chart's
appVersion
has been updated tov0.3.6
incharts/ceph-s3-operator/Chart.yaml
, which corresponds with the version mentioned in theREADME.md
. However, there is no evidence of the Helm chart's ownversion
being updated tov0.3.6
. This might indicate that the Helm chart itself may not have been updated to the new version, which could lead to inconsistencies or deployment issues. It is recommended to verify the Helm chart'sversion
field to ensure it matches the intended release version.Analysis chain
The Helm chart version has been updated from
v0.3.5
tov0.3.6
. Ensure that the Helm chart at the new version is available in the repository and that any dependent configurations or documentation have been updated accordingly.Scripts Executed
The following scripts were executed for the analysis:
Script:
Length of output: 85
Script:
Length of output: 348