Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly proxy compiler mode on make compiler helpers #1285

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Oct 11, 2024

Signed-off-by: Juan Cruz Viotti [email protected]

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Benchmark suite Current: b7c26d6 Previous: 1dff8cb Ratio
JSON_Array_Of_Objects_Unique 3879.334474699771 ns/iter 3645.8044525925984 ns/iter 1.06
JSONSchema_Validate_Draft4_Meta_1_No_Callback 805.009685663605 ns/iter 742.9591387674003 ns/iter 1.08
JSONSchema_Validate_Draft4_Required_Properties 1037.7177633980782 ns/iter 937.8226012435105 ns/iter 1.11
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 170.17035110088082 ns/iter 152.34727250519407 ns/iter 1.12
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 133.3128356344412 ns/iter 102.95383252814636 ns/iter 1.29
JSONSchema_Validate_Draft4_Items_Schema 3456.7033024003413 ns/iter 2616.6958973035626 ns/iter 1.32
JSONSchema_Validate_Draft4_Nested_Object 26.350079510428444 ns/iter 23.21692379281912 ns/iter 1.13
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1587.6908120630576 ns/iter 1275.711739585146 ns/iter 1.24
JSONSchema_Validate_Draft4_Properties_Triad_Closed 1117.2069379291174 ns/iter 977.3172626541307 ns/iter 1.14
JSONSchema_Validate_Draft4_Properties_Triad_Required 1788.6565943932228 ns/iter 1454.662886731709 ns/iter 1.23
JSONSchema_Validate_Draft4_Non_Recursive_Ref 246.92018430115152 ns/iter 218.8259922294332 ns/iter 1.13
JSONSchema_Validate_Draft4_Pattern_Properties_True 1691.8664074864487 ns/iter 1346.1148570929481 ns/iter 1.26
JSONSchema_Validate_Draft4_Ref_To_Single_Property 119.35798051848188 ns/iter 105.02933239530172 ns/iter 1.14
JSONSchema_Validate_Draft4_Additional_Properties_Type 452.89554024284456 ns/iter 406.60210477764764 ns/iter 1.11
JSONSchema_Validate_Draft4_Nested_Oneof 397.2907338670764 ns/iter 373.414562592075 ns/iter 1.06
JSONSchema_Validate_Draft6_Property_Names 876.2108819012751 ns/iter 781.3448634652449 ns/iter 1.12
JSONSchema_Validate_Draft7_If_Then_Else 194.10124671773337 ns/iter 172.36498298882643 ns/iter 1.13
JSONSchema_Compiler_Draft6_AdaptiveCard 3372514249.9999948 ns/iter 2887625999.9999547 ns/iter 1.17

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Benchmark suite Current: b7c26d6 Previous: 1dff8cb Ratio
JSON_Array_Of_Objects_Unique 2141.9969080977426 ns/iter 2197.216756198936 ns/iter 0.97
JSONSchema_Validate_Draft4_Meta_1_No_Callback 961.7235398991702 ns/iter 972.7178549544182 ns/iter 0.99
JSONSchema_Validate_Draft4_Required_Properties 1595.0422544820285 ns/iter 1614.6910811917624 ns/iter 0.99
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 181.43818531739416 ns/iter 181.61538733476021 ns/iter 1.00
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 131.15810444892648 ns/iter 129.9578128478961 ns/iter 1.01
JSONSchema_Validate_Draft4_Items_Schema 3498.7704867363705 ns/iter 3509.661896950024 ns/iter 1.00
JSONSchema_Validate_Draft4_Nested_Object 33.45966674644083 ns/iter 33.120863821716924 ns/iter 1.01
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1804.6181712999837 ns/iter 1783.151211509941 ns/iter 1.01
JSONSchema_Validate_Draft4_Properties_Triad_Closed 1521.2961687786394 ns/iter 1469.08672469018 ns/iter 1.04
JSONSchema_Validate_Draft4_Properties_Triad_Required 1878.3908833610192 ns/iter 1847.7535972834391 ns/iter 1.02
JSONSchema_Validate_Draft4_Non_Recursive_Ref 481.52799508108944 ns/iter 480.365058223926 ns/iter 1.00
JSONSchema_Validate_Draft4_Pattern_Properties_True 2423.5048103976874 ns/iter 2391.719039505017 ns/iter 1.01
JSONSchema_Validate_Draft4_Ref_To_Single_Property 133.94543950407737 ns/iter 133.75532873978995 ns/iter 1.00
JSONSchema_Validate_Draft4_Additional_Properties_Type 605.2665826341674 ns/iter 603.6879982005977 ns/iter 1.00
JSONSchema_Validate_Draft4_Nested_Oneof 475.7370260824121 ns/iter 470.8338664746431 ns/iter 1.01
JSONSchema_Validate_Draft6_Property_Names 1222.4491971382497 ns/iter 1243.5704803866413 ns/iter 0.98
JSONSchema_Validate_Draft7_If_Then_Else 217.05494287387876 ns/iter 205.96763564681928 ns/iter 1.05
JSONSchema_Compiler_Draft6_AdaptiveCard 5639870970.999937 ns/iter 5623182831.999998 ns/iter 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Benchmark suite Current: b7c26d6 Previous: 1dff8cb Ratio
JSONSchema_Compiler_Draft6_AdaptiveCard 6284163537.00004 ns/iter 6065963957.000009 ns/iter 1.04
JSONSchema_Validate_Draft4_Meta_1_No_Callback 1054.1644416471784 ns/iter 1077.0928668741874 ns/iter 0.98
JSONSchema_Validate_Draft4_Required_Properties 2233.665724073692 ns/iter 2282.7795306712383 ns/iter 0.98
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 193.8492211013426 ns/iter 195.61139430030642 ns/iter 0.99
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 138.99027521119402 ns/iter 139.78832370736902 ns/iter 0.99
JSONSchema_Validate_Draft4_Items_Schema 3055.9970091779987 ns/iter 3220.8174283047574 ns/iter 0.95
JSONSchema_Validate_Draft4_Nested_Object 28.08202490011922 ns/iter 22.742063395674027 ns/iter 1.23
JSONSchema_Validate_Draft4_Properties_Triad_Optional 1653.7259069716727 ns/iter 1738.7805705972419 ns/iter 0.95
JSONSchema_Validate_Draft4_Properties_Triad_Closed 1373.0743447155269 ns/iter 1436.4157799265056 ns/iter 0.96
JSONSchema_Validate_Draft4_Properties_Triad_Required 1736.9712658263716 ns/iter 1798.840020780207 ns/iter 0.97
JSONSchema_Validate_Draft4_Non_Recursive_Ref 465.06486187620766 ns/iter 447.7076137437281 ns/iter 1.04
JSONSchema_Validate_Draft4_Pattern_Properties_True 2224.2989875003623 ns/iter 2218.552804646964 ns/iter 1.00
JSONSchema_Validate_Draft4_Ref_To_Single_Property 143.8586689484877 ns/iter 146.60969120605048 ns/iter 0.98
JSONSchema_Validate_Draft4_Additional_Properties_Type 1086.5363302131648 ns/iter 1065.1916822971252 ns/iter 1.02
JSONSchema_Validate_Draft4_Nested_Oneof 427.82788892740916 ns/iter 432.957078212721 ns/iter 0.99
JSONSchema_Validate_Draft6_Property_Names 1564.7790599176672 ns/iter 1707.6437992956426 ns/iter 0.92
JSONSchema_Validate_Draft7_If_Then_Else 199.8426011843908 ns/iter 196.58164550423112 ns/iter 1.02
JSON_Array_Of_Objects_Unique 3402.042714058971 ns/iter 3271.052407966246 ns/iter 1.04

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Benchmark suite Current: b7c26d6 Previous: 1dff8cb Ratio
JSON_Array_Of_Objects_Unique 5344.633928570732 ns/iter 4960.616000000755 ns/iter 1.08
JSONSchema_Validate_Draft4_Meta_1_No_Callback 2370.7741397606765 ns/iter 2333.474069783572 ns/iter 1.02
JSONSchema_Validate_Draft4_Required_Properties 2219.3633475037514 ns/iter 2041.6563411338393 ns/iter 1.09
JSONSchema_Validate_Draft4_Many_Optional_Properties_Minimal_Match 551.5909821428165 ns/iter 555.8386000000155 ns/iter 0.99
JSONSchema_Validate_Draft4_Few_Optional_Properties_Minimal_Match 410.2805040053655 ns/iter 414.0654352333546 ns/iter 0.99
JSONSchema_Validate_Draft4_Items_Schema 6329.664285715353 ns/iter 6328.743750001666 ns/iter 1.00
JSONSchema_Validate_Draft4_Nested_Object 158.8768303571036 ns/iter 159.8698883928559 ns/iter 0.99
JSONSchema_Validate_Draft4_Properties_Triad_Optional 5366.771999999855 ns/iter 5386.312000000544 ns/iter 1.00
JSONSchema_Validate_Draft4_Properties_Triad_Closed 4418.2268750006415 ns/iter 4438.502618411801 ns/iter 1.00
JSONSchema_Validate_Draft4_Properties_Triad_Required 5457.662500000586 ns/iter 5522.990178570401 ns/iter 0.99
JSONSchema_Validate_Draft4_Non_Recursive_Ref 557.4361607143277 ns/iter 541.8884821429921 ns/iter 1.03
JSONSchema_Validate_Draft4_Pattern_Properties_True 8035.745535714003 ns/iter 7982.837130191873 ns/iter 1.01
JSONSchema_Validate_Draft4_Ref_To_Single_Property 416.155459100114 ns/iter 416.40147800925513 ns/iter 1.00
JSONSchema_Validate_Draft4_Additional_Properties_Type 751.3773437501925 ns/iter 743.4885044645005 ns/iter 1.01
JSONSchema_Validate_Draft4_Nested_Oneof 1092.5637500001528 ns/iter 1092.9434375000824 ns/iter 1.00
JSONSchema_Validate_Draft6_Property_Names 1936.0492143407098 ns/iter 1848.608079114365 ns/iter 1.05
JSONSchema_Validate_Draft7_If_Then_Else 561.9722321428965 ns/iter 564.8696000000655 ns/iter 0.99
JSONSchema_Compiler_Draft6_AdaptiveCard 10170194300.000048 ns/iter 9975128199.999971 ns/iter 1.02

This comment was automatically generated by workflow using github-action-benchmark.

@jviotti jviotti merged commit 4e7bbb0 into main Oct 11, 2024
13 checks passed
@jviotti jviotti deleted the context-helpers-make branch October 11, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant