Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly proxy compiler mode on make compiler helpers #1285

Merged
merged 1 commit into from
Oct 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/jsonschema/compile_helpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,11 @@ auto make(const bool report, const SchemaCompilerContext &context,
{dynamic_context.keyword}),
dynamic_context.base_instance_location,
to_uri(schema_context.relative_pointer, schema_context.base).recompose(),
schema_context.base.recompose(), context.uses_dynamic_scopes, report,
// TODO: Get value from the selected compilation mode
false, value};
schema_context.base.recompose(),
context.uses_dynamic_scopes,
report,
context.mode != SchemaCompilerMode::FastValidation,
value};
}

// Instantiate an applicator step
Expand All @@ -45,9 +47,12 @@ auto make(const bool report, const SchemaCompilerContext &context,
{dynamic_context.keyword}),
dynamic_context.base_instance_location,
to_uri(schema_context.relative_pointer, schema_context.base).recompose(),
schema_context.base.recompose(), context.uses_dynamic_scopes, report,
// TODO: Get value from the selected compilation mode
false, std::move(value), std::move(children)};
schema_context.base.recompose(),
context.uses_dynamic_scopes,
report,
context.mode != SchemaCompilerMode::FastValidation,
std::move(value),
std::move(children)};
}

template <typename Type, typename Step>
Expand Down