refactor(objects): removes unused classes and constructors #151
Conversation
clairekuang
changed the title
|
I'm loving this already |
clairekuang
requested review from
JR-Morgan,
adamhathcock,
AlanRynne and
didimitrie
| /// </summary> | ||
| [JsonIgnore, Obsolete("end angle should be calculated from arc endpoint and plane if needed", true)] | ||
| public double? endAngle { get; set; } |
There was a problem hiding this comment.
Technically, we could remove these, and it would not break the json layer.
| @@ -285,21 +145,19 @@ public List<double> ToList() | |||
| /// <returns>A new <see cref="Arc"/> with the values assigned from the list.</returns> | |||
| public static Arc FromList(List<double> list) | |||
There was a problem hiding this comment.
What did we say we'd do here r.e. v2
There was a problem hiding this comment.
decided to keep the list length the same as in V2 and just pass in dummy values for properties that were marked obsolete
| JsonProperty(NullValueHandling = NullValueHandling.Ignore), | ||
| Obsolete("Access coordinates using XYZ and weight fields", true) | ||
| ] | ||
| private new List<double> value |
Uses a new objects test in Revit for serialization tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #151 +/- ##
===========================================
+ Coverage 33.26% 63.93% +30.67%
===========================================
Files 378 223 -155
Lines 12374 8773 -3601
Branches 1061 989 -72
===========================================
+ Hits 4116 5609 +1493
+ Misses 8013 2884 -5129
- Partials 245 280 +35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Claire is going to patch in a deserialization target for Revit instances, blocks, and maybe a couple others where we're not happy with the change to dynamic traversal.
I've suggested using a single class for this, and use multiple DeprecatedSpeckleTypeAttributes
I can see no risky changes in any of the modified object models, except arc which is known about and acceptable.
Otherwise, everything here is great. Claire and Bilal have been very through with testing.
…dds deprecated v2 classes
…tps://github.com/specklesystems/speckle-sharp-sdk into claire/cnx-687-purge-unused-classes-from-objects
AlanRynne
deleted the
claire/cnx-687-purge-unused-classes-from-objects
branch
This is a deep clean of our
Objectsclasses, including:Schemaconstructors and flags)requiredkeywords and nullability where knownobsoleteandjsonignoreLegacyV2class with deprecation flags for any removed classes that we do not want dynamically traversed (eg blocks, views, parameters).The target behavior of V2 -> V3 receives after this pr should remain mostly the same as release:
Base, and display values are received where they existSee testing results in: https://linear.app/speckle/issue/CNX-713/objects-testing