Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base vaults and strategies upgrade & QSMF #100

Merged
merged 11 commits into from
Mar 5, 2024

DeployUpdateVaultsAndStrategiesPolygon

ad8118d
Select commit
Loading
Failed to load commit list.
Merged

Base vaults and strategies upgrade & QSMF #100

DeployUpdateVaultsAndStrategiesPolygon
ad8118d
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Semgrep OSS succeeded Mar 5, 2024 in 4s

3 new alerts

New alerts in code changed by this pull request

  • 3 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 37 in src/strategies/libs/QSMFLib.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 52 in src/strategies/libs/QSMFLib.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.

Check notice on line 198 in src/core/base/VaultBase.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.performance.use-nested-if Note

Using nested is cheaper than using && multiple check combinations.
There are more advantages, such as easier to read code and better coverage reports.