Remove all mentions of Sysdig and Falco in our codebase #1346
Conversation
|
Skipping CI for Draft Pull Request. |
|
Molter73
force-pushed
the
mauro/remove-sysdig-references
branch
2 times, most recently
from
6cb4a33
to
5264462
Compare
Molter73
force-pushed
the
mauro/remove-sysdig-references
branch
3 times, most recently
from
79565ad
to
9fb5f73
Compare
This is a long due change, all mentions of Sysdig and Falco have been replaced by a more generic system_inspector name.
Molter73
force-pushed
the
mauro/remove-sysdig-references
branch
from
9fb5f73
to
e1f53ba
Compare
| @@ -1,10 +1,9 @@ | |||
| #include "SysdigService.h" | |||
| #include "gmock/gmock.h" | |||
There was a problem hiding this comment.
Interesting, it wasn't used here?
There was a problem hiding this comment.
It wasn't, the tests use full fledged Falco objects instead of mocks, they just doesn't instruct the inspector to start collecting data.
| @@ -315,10 +315,10 @@ Note that the `[syscall]` suffix in a metric name means that it is instanciated | |||
|
|
|||
| Note that if ProcfsScraper is unable to open /proc it is not able to open any of the subdirectories, but only procfs_could_not_open_proc_dir will be incremented in that case. | |||
|
|
|||
| ### Falco timers per syscall | |||
| ### system_inspector timers per syscall | |||
There was a problem hiding this comment.
It's probably worth mentioning somewhere before this point, that system_inspector in the current incarnation is actually nothing more than Falco inspector.
There was a problem hiding this comment.
Makes sense, I'll find a place for it.
collector/lib/CollectorService.h
Outdated
|
|
||
| namespace collector { | ||
|
|
||
| class SysdigService; | ||
| class Service; |
There was a problem hiding this comment.
A nitpick, but can this be referred to by the fully qualified name, with the namespace? Otherwise the name "Service" is quite generic, and if it could be consistently used everywhere with the "system_inspector" (as everywhere else in this PR), that would be great.
collector/lib/CMakeLists.txt
Outdated
| @@ -0,0 +1,62 @@ | |||
| set(COLLECTOR_LIB_SRC_FILES | |||
There was a problem hiding this comment.
Are you sure about switching from *.cpp to the exact list of files? Might be coming as a surprise for unprepared developers.
There was a problem hiding this comment.
I just prefer the explicit way of listing source files with cmake, (I believe this is also the recommended way to do things, since globbing *.cpp can cause things like new files not being added to already configured builds), but you are probably right that this is not the place to make this change, I'll roll it back and we can circle back to it at a later point.
Description
This is a long due change, all mentions of Sysdig and Falco have been replaced by a more generic system_inspector name. No functional change has been made, the PR is purely organizational.
Checklist
Testing Performed
CI should be enough, since things are just being shuffled around.