-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all mentions of Sysdig and Falco in our codebase #1346
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e1f53ba
Remove all mentions of Sysdig and Falco in our codebase
Molter73 ebb1cf3
Describe integration with falco libraries
Molter73 6fe1b4f
Roll back cmake to using globing patterns for source files
Molter73 6c97154
Improved system_inspector namespace consistency
Molter73 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
set(COLLECTOR_LIB_SRC_FILES | ||
NetworkConnection.cpp | ||
CollectorConfig.cpp | ||
CollectorArgs.cpp | ||
SignalServiceClient.cpp | ||
RateLimit.cpp | ||
Process.cpp | ||
ProtoUtil.cpp | ||
Logging.cpp | ||
HostInfo.cpp | ||
ProfilerHandler.cpp | ||
GetStatus.cpp | ||
FileDownloader.cpp | ||
AbortHandler.cpp | ||
ProcfsScraper.cpp | ||
EventNames.cpp | ||
CollectorService.cpp | ||
NetworkSignalHandler.cpp | ||
CollectionMethod.cpp | ||
GRPCUtil.cpp | ||
NetworkStatusNotifier.cpp | ||
NRadix.cpp | ||
GRPC.cpp | ||
GetKernelObject.cpp | ||
HostHeuristics.cpp | ||
DriverCandidates.cpp | ||
CollectorStatsExporter.cpp | ||
SelfCheckHandler.cpp | ||
CollectorStats.cpp | ||
ConnTracker.cpp | ||
StoppableThread.cpp | ||
Utility.cpp | ||
ProcessSignalHandler.cpp | ||
ProcessSignalFormatter.cpp | ||
NetworkConnectionInfoServiceComm.cpp | ||
SelfChecks.cpp | ||
LogLevel.cpp | ||
system-inspector/Service.cpp | ||
system-inspector/EventExtractor.cpp | ||
) | ||
add_library(collector_lib ${DRIVER_HEADERS} ${COLLECTOR_LIB_SRC_FILES}) | ||
add_dependencies(collector_lib sinsp) | ||
target_link_libraries(collector_lib sinsp) | ||
target_link_libraries(collector_lib stdc++fs) # This is needed for GCC-8 to link against the filesystem library | ||
target_link_libraries(collector_lib cap-ng) | ||
target_link_libraries(collector_lib uuid) | ||
target_link_libraries(collector_lib libgrpc++.a libgrpc.a libgpr.a libupb.a libabsl_bad_optional_access.a libabsl_base.a libabsl_log_severity.a libabsl_spinlock_wait.a libabsl_str_format_internal.a libabsl_strings.a libabsl_strings_internal.a libabsl_throw_delegate.a libabsl_int128.a libabsl_raw_logging_internal.a libaddress_sorting.a) | ||
target_link_libraries(collector_lib civetweb-cpp civetweb) | ||
|
||
target_link_libraries(collector_lib rox-proto) | ||
|
||
if(DEFINED ENV{WITH_RHEL_RPMS}) | ||
target_link_libraries(collector_lib protobuf cares) | ||
else() | ||
target_link_libraries(collector_lib libprotobuf.a libcares.a) | ||
endif() | ||
|
||
if(NOT DISABLE_PROFILING) | ||
target_link_libraries(collector_lib profiler tcmalloc) | ||
endif() | ||
|
||
target_link_libraries(collector_lib z ssl crypto CURL::libcurl bpf) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,11 +7,11 @@ | |
#include "CollectorStats.h" | ||
#include "Control.h" | ||
#include "DriverCandidates.h" | ||
#include "SysdigService.h" | ||
#include "system-inspector/Service.h" | ||
|
||
namespace collector { | ||
|
||
class SysdigService; | ||
class Service; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A nitpick, but can this be referred to by the fully qualified name, with the namespace? Otherwise the name "Service" is quite generic, and if it could be consistently used everywhere with the "system_inspector" (as everywhere else in this PR), that would be great. |
||
|
||
class CollectorService { | ||
public: | ||
|
@@ -29,7 +29,7 @@ class CollectorService { | |
std::atomic<ControlValue>* control_; | ||
const std::atomic<int>& signum_; | ||
|
||
SysdigService sysdig_; | ||
system_inspector::Service system_inspector_; | ||
}; | ||
|
||
bool SetupKernelDriver(CollectorService& collector, const std::string& GRPCServer, const CollectorConfig& config); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about switching from
*.cpp
to the exact list of files? Might be coming as a surprise for unprepared developers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just prefer the explicit way of listing source files with cmake, (I believe this is also the recommended way to do things, since globbing
*.cpp
can cause things like new files not being added to already configured builds), but you are probably right that this is not the place to make this change, I'll roll it back and we can circle back to it at a later point.