Make tests verbose about startup failures #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erthalion
force-pushed
the
feature/make-tests-verbose-about-startup-failures
branch
from
930d27b
to
acd379f
Compare
Stringy
approved these changes
Dec 15, 2023
erthalion
force-pushed
the
feature/make-tests-verbose-about-startup-failures
branch
2 times, most recently
from
a12fbd4
to
dc4c247
Compare
In the past we've got situations when the CI integration tests reports were not extensive enough to clarify what's going on, and we were launching a full-blown debugging process just to find out that the probes were missing. To make initialization issues more visible, make integration tests verbose about them: * Introduce a HEALTHCHECK for the Collector docker image, based on the /ready Civet API. This command would be ignored on K8S, but we could use it on CI for containers filtering. * Wait for Collector container to become healthy first before proceeding with the rest of tests. This will make it immediately clear if the test is failing due to missing probes. * Make self-checks verification a hard failure. Currently, we wait for the self-checks, but do not report if they're missing. This change will make it clear if something is badly broken to the extent that we don't receive any events.
erthalion
force-pushed
the
feature/make-tests-verbose-about-startup-failures
branch
from
dc4c247
to
82303a0
Compare
Taking into account volatile nature of integration tests, it's improbable that exactly N processes could be observed during any test. At the same time we actually want to assert that at least N processes were observed (e.g. at least 1 to make sure we've got self-checks). Modify the condition to follow "at least N" approach.
Container doesn't have xargs.
Reduce waiting threshold, make errors more verbose.
erthalion
deleted the
feature/make-tests-verbose-about-startup-failures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the past we've got situations when the CI integration tests reports were not extensive enough to clarify what's going on, and we were launching a full-blown debugging process just to find out that the probes were missing.
To make initialization issues more visible, make integration tests verbose about them:
Introduce a HEALTHCHECK for the Collector docker image, based on the /ready Civet API. This command would be ignored on K8S, but we could use it on CI for containers filtering.
Wait for Collector container to become healthy first before proceeding with the rest of tests. This will make it immediately clear if the test is failing due to missing probes.
Make self-checks verification a hard failure. Currently, we wait for the self-checks, but do not report if they're missing. This change will make it clear if something is badly broken to the extent that we don't receive any events.
Checklist
Testing Performed
Local testing, but CI is sufficient.