Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests verbose about startup failures #1473

Merged
merged 4 commits into from
Dec 19, 2023

Commits on Dec 15, 2023

  1. Make tests verbose about startup failures

    In the past we've got situations when the CI integration tests reports
    were not extensive enough to clarify what's going on, and we were
    launching a full-blown debugging process just to find out that the
    probes were missing.
    
    To make initialization issues more visible, make integration tests
    verbose about them:
    
    * Introduce a HEALTHCHECK for the Collector docker image, based on the
    /ready Civet API. This command would be ignored on K8S, but we could use
    it on CI for containers filtering.
    
    * Wait for Collector container to become healthy first before proceeding
    with the rest of tests. This will make it immediately clear if the test
    is failing due to missing probes.
    
    * Make self-checks verification a hard failure. Currently, we wait for
    the self-checks, but do not report if they're missing. This change will
    make it clear if something is badly broken to the extent that we don't
    receive any events.
    erthalion committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    82303a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Fix WaitProcessesN to wait at least for N procs

    Taking into account volatile nature of integration tests, it's
    improbable that exactly N processes could be observed during any test.
    At the same time we actually want to assert that at least N processes
    were observed (e.g. at least 1 to make sure we've got self-checks).
    Modify the condition to follow "at least N" approach.
    erthalion committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    2ca55eb View commit details
    Browse the repository at this point in the history
  2. Remove xargs

    Container doesn't have xargs.
    erthalion committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b25c7ab View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Make failures more obvious

    Reduce waiting threshold, make errors more verbose.
    erthalion committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    a6ffc2c View commit details
    Browse the repository at this point in the history