Adds multiple s390x zones, and rescue for failed VSI creation #1700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As with GCP, we need to failover to a different zone if VM creation fails. This also handles the clean up of failed VSI creation. The root cause was related to the generation of the ansible inventory - if the creation fails the VSI exists but isn't added to the inventory so subsequent attempts to clean up find nothing to do. Instead, failed VMs are immediately cleaned up
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI should be largely sufficient
Manual tests: