Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds multiple s390x zones, and rescue for failed VSI creation #1700

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Stringy
Copy link
Collaborator

@Stringy Stringy commented Jun 5, 2024

Description

As with GCP, we need to failover to a different zone if VM creation fails. This also handles the clean up of failed VSI creation. The root cause was related to the generation of the ansible inventory - if the creation fails the VSI exists but isn't added to the inventory so subsequent attempts to clean up find nothing to do. Instead, failed VMs are immediately cleaned up

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

CI should be largely sufficient

Manual tests:

  • Normal successful run creates the VM and doesn't attempt second creation in the other zone
  • Failure after creation attempts to clean up resources
  • Failure after first attempt tries to use other zone

@Stringy Stringy added the run-multiarch-builds Run steps for non-x86 archs. label Jun 5, 2024
@Stringy Stringy force-pushed the giles/s390x-vm-creation-robustness branch from 9a2e54a to 32f7d73 Compare June 6, 2024 08:58
@Stringy Stringy marked this pull request as ready for review June 6, 2024 12:03
@Stringy Stringy requested a review from a team as a code owner June 6, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-multiarch-builds Run steps for non-x86 archs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant