Revert "QUIC Initial Packet Decryption and Parsing" #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2024
This was referenced Sep 7, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #37
#37 breaks compilation on ARM machines. It seems like not a straightforward fix, so I'm reverting for now to keep the main branch stable.
Note: will open a separate issue to make ARM compilation a pre-checkin test.
The error is in the rust-crypto crate and looks like this:
.cargo/registry/src/index.crates.io-6f17d22bba15001f/rust-crypto-0.2.36/src/util.rs:52: undefined reference torust_crypto_util_fixed_time_eq_asm'`DaGenix/rust-crypto#383 suggests that rust-crypto is no longer maintained. It will have to be replaced by a different library.