Add support for inline completions (WIP) #2552
Conversation
✅ Deploy Preview for sublime-lsp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jwortmann
force-pushed
the
inline-completions
branch
from
e9e738d
to
9c4fb88
Compare
jwortmann
force-pushed
the
inline-completions
branch
from
9c4fb88
to
2d6aed5
Compare
| session = self.best_session(self.capability, point) | ||
| if not session: | ||
| return | ||
| if self.view.settings().get('mini_auto_complete', False): |
There was a problem hiding this comment.
hahahaha I was wondering why this PR doesn't work for me, it was due to this check.
I had mini_auto_complete enabled.
| // {"key": "auto_complete_visible"} | ||
| // ] | ||
| // }, | ||
| // Insert Inline Completion | ||
| { | ||
| "keys": ["alt+enter"], |
There was a problem hiding this comment.
What do you think of using tab for committing an inline completion?
There was a problem hiding this comment.
I'm aware that Tab is used for it in VSCode and I think also in other IDEs like IntelliJ. But I doubt that it would be a good choice in Sublime; personally I use Tab to commit regular auto-complete ("auto_complete_commit_on_tab": true) and there are probably many users who do the same. I think we should use a key binding which is definitely not already in use by Sublime Text. However Alt + Enter is not the most ergonomic to use though; here I used it mostly for testing but we can discuss whether we find something better. Or maybe it should be left without any key binding by default and require users to set up an own key binding for it.
This is true. |
| listener.inline_completion.position = position | ||
| listener.inline_completion.render_async(0) | ||
|
|
||
| # filter_text = item.get('filterText', insert_text) # ignored for now |
| return False | ||
| return listener.inline_completion.visible | ||
|
|
||
| def run(self, edit: sublime.Edit, event: dict | None = None, point: int | None = None) -> None: |
| "LspNextDiagnosticCommand", | ||
| "LspNextInlineCompletionCommand", |
There was a problem hiding this comment.
I am not sure how to test the LspNextInlineCompletionCommand
There was a problem hiding this comment.
Currently I trigger the autocomple,
that also triggers the inline completions request,
and I will see the inline completion phantom,
When I trigger the LspNextInlineCompletionCommand, I expect to see a different inline completion phantom, but I still see the same phantom. Do you see a different phantom when triggering the LspNextInlineCompletionCommand?
There was a problem hiding this comment.
In my experiments, Tabby always provides only a single inline completion item. So it's expected that currently nothing happens when you trigger that command.
Experimental / work in progress
Implementation details are open for discussion and it would be nice to gather some opinions how inline completions should work.
It can be tested with Tabby; for setup see #2520 or the docs description which is added in this PR. Tabby requires a compatible GPU.
For this PR I hijacked the Alt + Enter key binding which is currently used for "insert completion with opposite insert mode", because there aren't really any good key bindings left (everything with Ctrl or Shift is already taken in the ST default key bindings). This was mostly for testing and is up for discussion I guess.
I haven't really looked at the implementations in e.g. LSP-copilot yet. Perhaps there are some improvements that we can adopt.