-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for inline completions (WIP) #2552
base: main
Are you sure you want to change the base?
Changes from all commits
57f6a30
2d6aed5
5c773e0
2080f75
6dc8dc2
3063b62
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,6 +59,9 @@ | |
from .plugin.hover import LspToggleHoverPopupsCommand | ||
from .plugin.inlay_hint import LspInlayHintClickCommand | ||
from .plugin.inlay_hint import LspToggleInlayHintsCommand | ||
from .plugin.inline_completion import LspCommitInlineCompletionCommand | ||
from .plugin.inline_completion import LspInlineCompletionCommand | ||
from .plugin.inline_completion import LspNextInlineCompletionCommand | ||
from .plugin.panels import LspClearLogPanelCommand | ||
from .plugin.panels import LspClearPanelCommand | ||
from .plugin.panels import LspShowDiagnosticsPanelCommand | ||
|
@@ -99,6 +102,7 @@ | |
"LspCollapseTreeItemCommand", | ||
"LspColorPresentationCommand", | ||
"LspCommitCompletionWithOppositeInsertMode", | ||
"LspCommitInlineCompletionCommand", | ||
"LspCopyToClipboardFromBase64Command", | ||
"LspDisableLanguageServerGloballyCommand", | ||
"LspDisableLanguageServerInProjectCommand", | ||
|
@@ -120,7 +124,9 @@ | |
"LspHierarchyToggleCommand", | ||
"LspHoverCommand", | ||
"LspInlayHintClickCommand", | ||
"LspInlineCompletionCommand", | ||
"LspNextDiagnosticCommand", | ||
"LspNextInlineCompletionCommand", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure how to test the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currently I trigger the autocomple, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In my experiments, Tabby always provides only a single inline completion item. So it's expected that currently nothing happens when you trigger that command. |
||
"LspOnDoubleClickCommand", | ||
"LspOpenLinkCommand", | ||
"LspOpenLocationCommand", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of using
tab
for committing an inline completion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware that Tab is used for it in VSCode and I think also in other IDEs like IntelliJ. But I doubt that it would be a good choice in Sublime; personally I use Tab to commit regular auto-complete (
"auto_complete_commit_on_tab": true
) and there are probably many users who do the same. I think we should use a key binding which is definitely not already in use by Sublime Text. However Alt + Enter is not the most ergonomic to use though; here I used it mostly for testing but we can discuss whether we find something better. Or maybe it should be left without any key binding by default and require users to set up an own key binding for it.