Be/#185 Comment 도메인 리팩토링 및 테스트 코드 수정 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimhalin
reviewed
Aug 17, 2023
Comment on lines
-39
to
-40
| public ResponseEntity<ResultResponse> updateComment(@Validated @RequestBody UpdateCommentRequest dto, @PathVariable Long commentId, @CurrentUser Member loginUser) { | ||
| commentService.updateComment(commentId, dto); |
There was a problem hiding this comment.
@currentuser 같은 경우에는 당장 사용하지 않아서 삭제하신 거죠!? 댓글은 작성자만 삭제할 수 있도록 하는 로직이 나중에는 필요할 것 같긴해요 !
There was a problem hiding this comment.
mapper 따로 안 만들고 dto 클래스 내에 함수로 생성하기로 했었습니다! 확인 부탁드려용
kimhalin
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ 변경사항
☝️ 유의사항
👀 참고자료
❗체크리스트