-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be/#185 Comment 도메인 리팩토링 및 테스트 코드 수정 #187
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dfe608d
refactor : Comment 도메인 리팩토링
youKeon 649546e
test : Comment 도메인 컨트롤러 계층 테스트 코드 수정
youKeon 3ef3425
refactor : 댓글 생성 API 유효성 검사 추가
youKeon 5efc3be
refactor : 답글 조회 메서드 유효성 검사 추가
youKeon 1ad3d5d
test : Comment 도메인 서비스 계층 테스트 코드 작성
youKeon 6d57f49
test : Comment 도메인 리포지토리 계층 테스트 코드 작성
youKeon efc72f7
test : CommentServiceTest 테스트 코드 메소드 명 수정
youKeon 78250fd
test : CommentRepository 테스트 코드 수정
youKeon 9610c16
refactor : GetProjectDetailResponse DTO 패키지 변경
youKeon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 0 additions & 79 deletions
79
backend/src/main/java/com/graphy/backend/domain/comment/dto/CommentDto.java
This file was deleted.
Oops, something went wrong.
38 changes: 38 additions & 0 deletions
38
...end/src/main/java/com/graphy/backend/domain/comment/dto/request/CreateCommentRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package com.graphy.backend.domain.comment.dto.request; | ||
|
||
import com.graphy.backend.domain.comment.domain.Comment; | ||
import com.graphy.backend.domain.member.domain.Member; | ||
import com.graphy.backend.domain.project.domain.Project; | ||
import lombok.AllArgsConstructor; | ||
import lombok.Builder; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
|
||
import javax.validation.constraints.NotBlank; | ||
import javax.validation.constraints.NotNull; | ||
|
||
@Getter | ||
@Builder | ||
@NoArgsConstructor | ||
@AllArgsConstructor | ||
public class CreateCommentRequest { | ||
|
||
@NotBlank | ||
private String content; | ||
|
||
@NotNull | ||
private Long projectId; | ||
|
||
private Long parentId; | ||
|
||
public Comment toEntity(Project project, | ||
Comment parentComment, | ||
Member member) { | ||
return Comment.builder() | ||
.member(member) | ||
.content(content) | ||
.parent(parentComment) | ||
.project(project) | ||
.build(); | ||
} | ||
} |
17 changes: 17 additions & 0 deletions
17
...end/src/main/java/com/graphy/backend/domain/comment/dto/request/UpdateCommentRequest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
package com.graphy.backend.domain.comment.dto.request; | ||
|
||
import lombok.AllArgsConstructor; | ||
import lombok.Builder; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
|
||
import javax.validation.constraints.NotBlank; | ||
|
||
@Getter | ||
@Builder | ||
@NoArgsConstructor | ||
@AllArgsConstructor | ||
public class UpdateCommentRequest { | ||
@NotBlank | ||
private String content; | ||
} |
14 changes: 14 additions & 0 deletions
14
...d/src/main/java/com/graphy/backend/domain/comment/dto/response/CreateCommentResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package com.graphy.backend.domain.comment.dto.response; | ||
|
||
import lombok.AllArgsConstructor; | ||
import lombok.Builder; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
|
||
@Getter | ||
@Builder | ||
@AllArgsConstructor | ||
@NoArgsConstructor | ||
public class CreateCommentResponse { | ||
private Long commentId; | ||
} |
20 changes: 20 additions & 0 deletions
20
...in/java/com/graphy/backend/domain/comment/dto/response/GetCommentWithMaskingResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package com.graphy.backend.domain.comment.dto.response; | ||
|
||
import lombok.AllArgsConstructor; | ||
import lombok.Builder; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
|
||
import java.time.LocalDateTime; | ||
|
||
@Getter | ||
@Builder | ||
@AllArgsConstructor | ||
@NoArgsConstructor | ||
public class GetCommentWithMaskingResponse { | ||
private String content; | ||
private Long commentId; | ||
private LocalDateTime createdAt; | ||
private String nickname; | ||
private Long childCount; | ||
} |
29 changes: 29 additions & 0 deletions
29
...nd/src/main/java/com/graphy/backend/domain/comment/dto/response/GetReplyListResponse.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
package com.graphy.backend.domain.comment.dto.response; | ||
|
||
import com.graphy.backend.domain.comment.domain.Comment; | ||
import lombok.AllArgsConstructor; | ||
import lombok.Builder; | ||
import lombok.Getter; | ||
import lombok.NoArgsConstructor; | ||
|
||
import java.time.LocalDateTime; | ||
|
||
@Getter | ||
@Builder | ||
@AllArgsConstructor | ||
@NoArgsConstructor | ||
public class GetReplyListResponse { | ||
private String nickname; | ||
private String content; | ||
private Long commentId; | ||
private LocalDateTime createdAt; | ||
|
||
public static GetReplyListResponse from(Comment comment) { | ||
return GetReplyListResponse.builder() | ||
.nickname(comment.getMember().getNickname()) | ||
.content(comment.getContent()) | ||
.commentId(comment.getId()) | ||
.createdAt(comment.getCreatedAt()) | ||
.build(); | ||
} | ||
} |
7 changes: 4 additions & 3 deletions
7
...d/src/main/java/com/graphy/backend/domain/comment/repository/CommentCustomRepository.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
package com.graphy.backend.domain.comment.repository; | ||
|
||
|
||
import com.graphy.backend.domain.comment.domain.Comment; | ||
import com.graphy.backend.domain.comment.dto.response.GetCommentWithMaskingResponse; | ||
import com.graphy.backend.domain.comment.dto.response.GetReplyListResponse; | ||
|
||
import java.util.List; | ||
|
||
import static com.graphy.backend.domain.comment.dto.CommentDto.*; | ||
|
||
public interface CommentCustomRepository { | ||
List<GetCommentWithMaskingResponse> findCommentsWithMasking(Long id); | ||
List<GetReplyListResponse> findReplyList(Long parentId); | ||
List<Comment> findReplyList(Long parentId); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@currentuser 같은 경우에는 당장 사용하지 않아서 삭제하신 거죠!? 댓글은 작성자만 삭제할 수 있도록 하는 로직이 나중에는 필요할 것 같긴해요 !